New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View "PHP-configs used by domain" not valid #532

Open
rseffner opened this Issue Mar 13, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@rseffner

rseffner commented Mar 13, 2018

Summary

View "PHP-configs" shown an config as "not used" but it ist used by one domain.

System information

  • Froxlor version: 0.9.39.5
  • Web server: apache2
  • DNS server: bind
  • POP/IMAP server: Dovecot
  • SMTP server: postfix
  • FTP server: proftpd
  • OS/Version: debian 8

Steps to reproduce

  1. there is a second admin, managing his own customers
  2. this admin allows one of his customers a bunch of php-configs
  3. this customer selected on php-config for one of his subdomains
  4. phpinfo an the fcgi-starter-script shows using selected php-config
  5. looking in php - php-configs, these config isn't used - perhaps in this special case of "only" a subdomain uses this config

Expected behavior

  1. every uses php-config should shown as used to not delete them bei cleaning operations

Actual behavior

  1. looking in php - php-configs, these config isn't used - perhaps in this special case of "only" a subdomain uses this config
@d00p

This comment has been minimized.

Member

d00p commented Mar 13, 2018

Subdomains are not shown in the list of php-configs

@rseffner

This comment has been minimized.

rseffner commented Mar 13, 2018

Please look at this case from a differnet point of view to answer th question "why not?".
If an server admin checks his php configurations for unsupported versions or insecure configurations to clean up his system its dangerous to shom him unused php configuration sets which were still not unused. The output "is not used" ist still wrong!

@d00p

This comment has been minimized.

Member

d00p commented Mar 13, 2018

I did not say "no" nor did i close this ticket, i just wanted to clearify the current state

@d00p d00p self-assigned this Mar 13, 2018

@rseffner

This comment has been minimized.

rseffner commented Mar 13, 2018

I also only liked to suggest to change the counting behavior or to clearify the output. In my use case, also mentioning subdomians will be the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment