New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing PHP extensions should spawn so many lock files #552

Closed
michaelzangl opened this Issue May 6, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@michaelzangl
Contributor

michaelzangl commented May 6, 2018

If a PHP extension is missing (e.g. after PHP update), the correspronding cron jobs fail and keep a lock- file in the lock directory.

After several attempts, the whole directory is full with files like this:

froxlor_froxlor_master_cronjob-letsencrypt.lock-1003
froxlor_froxlor_master_cronjob-letsencrypt.lock-10030
froxlor_froxlor_master_cronjob-letsencrypt.lock-10031
froxlor_froxlor_master_cronjob-letsencrypt.lock-10032
froxlor_froxlor_master_cronjob-letsencrypt.lock-10034

(for each cron job).

It seems to be intended to keep the lock if a job fails, but the test if the lock exists should be moved as early as possible - that is before the PHP module checks. That way, we only get one lock file to clean up.

@d00p

This comment has been minimized.

Member

d00p commented May 6, 2018

lock files are being checked, see https://github.com/Froxlor/Froxlor/blob/master/lib/cron_init.php#L105
Also, could you please state which extension was missing?

@d00p

This comment has been minimized.

Member

d00p commented Oct 15, 2018

no response

@d00p d00p closed this Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment