New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Backup of last working config files in sites-enabled #554

Open
HardyKrause opened this Issue May 24, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@HardyKrause

HardyKrause commented May 24, 2018

There should be a backup of the last known working config-files in the sites-enabled folder before creating the new config-files.

Reason: It happened sometimes that after changing the config of a domain (probably in the SSL part) the web server was not reachable because an error in a conf file.
Because I have to recover the server very quick I would like to copy back the working backup.

@d00p

This comment has been minimized.

Member

d00p commented May 24, 2018

Our configs are generated on-the-fly with current settings...we would need to log every change made to domains and settings between the cron-runs and even then, how would you access froxlor to revert to a known state if the webserver does not start? Easier said than done...the basic idea is reasonable and makes total sense...but it's not that easy.

Another approach would be to "move" the to-be-overwritten vhost-configs to a backup-location prior to re-generation every time. Danger here: if the cronjob runs again (ok, froxlor not working, no changes are possible, no re-generation but you can run it manually with --force to trigger it) you backup is being overwritten with non-working vhosts...

In addition to the second approach, you could easily write a simple bash script that does some kind of "vhost-config-backup" prior to a webserver-restart and place that as "webserver restart command" in the settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment