New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support PGP encryption for backups #590

Open
MatthiasLohr opened this Issue Nov 20, 2018 · 10 comments

Comments

Projects
None yet
2 participants
@MatthiasLohr
Copy link

MatthiasLohr commented Nov 20, 2018

Froxlor should support PGP encryption of backups to increase security. That could be realized by adding a field pgp_public_key to the users basic data or within the backup dialog. After the backup archive was created successfully, and a pgp key is available, the archive should be encrypted, so only the owner of the according private key is able to read that backup.

That would be especially useful if it takes a long time to create the backup (e.g. overnight) and you do not want to have your plaintext backup stored that long.

What do you think about that?

Best regards
Matthias

@d00p

This comment has been minimized.

Copy link
Member

d00p commented Nov 20, 2018

Well, the "backup" feature is more like a "retreive all my data" for customers. If you want a REAL backup (with possibilities to restore, etc.) you should use something specially designed for that task. Froxlor will never integrate a full features backup functionality as there are so many (opensource) projects that do a great job at this already and which are focusing on that.

@d00p d00p closed this Nov 20, 2018

@MatthiasLohr

This comment has been minimized.

Copy link

MatthiasLohr commented Nov 20, 2018

Then let's rename it so "Support PGP encryption for 'retreive all my data'". Would ask for the same feature for that.

@d00p

This comment has been minimized.

Copy link
Member

d00p commented Nov 20, 2018

Well, I'm not sure many people will use that but hey, why not. Are you interested in providing a PullRequest? :)

@d00p d00p reopened this Nov 20, 2018

@MatthiasLohr

This comment has been minimized.

Copy link

MatthiasLohr commented Nov 20, 2018

Yes, why not. Give me some time for implementing this (I first have to (re)learn the structure of Froxlor). Thanks for reopening the feature request.

@MatthiasLohr

This comment has been minimized.

Copy link

MatthiasLohr commented Nov 27, 2018

@d00p, I have now some code prepared (currently in testing stage). Does a pull request has a change to get merged (regarding the 0.10 rewrite) for 0.9.x?

@d00p

This comment has been minimized.

Copy link
Member

d00p commented Nov 27, 2018

No new features in 0.9.x

@MatthiasLohr

This comment has been minimized.

Copy link

MatthiasLohr commented Nov 27, 2018

Then I will wait for 0.10 for providing a pull request.

@d00p

This comment has been minimized.

Copy link
Member

d00p commented Nov 27, 2018

Why wait? 0.10.0 is current MASTER

@MatthiasLohr

This comment has been minimized.

Copy link

MatthiasLohr commented Nov 27, 2018

Because it's not released yet. I want to have a stable code base for developing this feature. Otherwise, I have to rearrange the pull request after possible major changes in your code - and I don't now how "finalized" the code is right now ("Like every other version before: when its done"), so I will wait.

@d00p

This comment has been minimized.

Copy link
Member

d00p commented Nov 27, 2018

As said, there will be no new features added to 0.9.x as the next major release will be 0.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment