Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom SSL vhost setting option should be active by default #739

Closed
tnebe opened this issue Oct 24, 2019 · 4 comments
Assignees
Projects
Milestone

Comments

@tnebe
Copy link

@tnebe tnebe commented Oct 24, 2019

Summary

With froxlor 0.10.2 an option has been introduced to set different custom vhost settings per domain for SSL and non-SSL configurations.
Before that only one custom configuration was applied to both vhost container.

This causes an issue when performing the upgrade - existing SSL domains lose the previous set custom vhost configuration.

Therefore the option to share the config from non-SSL host should be checked by default.

System information

  • Froxlor version: 0.10.2
  • Web server: apache2
@d00p

This comment has been minimized.

Copy link
Member

@d00p d00p commented Oct 24, 2019

When updating from 0.10.1 to 0.10.2 (when this was introduced) for UPDATERS the include_specialsettings option is enabled for all ssl IP's which have content in specialsettings - so I don't understand why this is an issue. For new users and new IP/Ports this can be explicitly set. That's why this is two fields and optional to use one for both.

@d00p d00p self-assigned this Oct 24, 2019
@d00p d00p added this to To do in 0.10.x via automation Oct 24, 2019
@d00p d00p added this to the 0.10.3 milestone Oct 24, 2019
@tnebe

This comment has been minimized.

Copy link
Author

@tnebe tnebe commented Oct 24, 2019

The option was definetely not set to enabled for all of my domains where I had defined specialsettings inside. I updated from 0.9.40 to 0.10.2.

I feel it would make more sense to have this option activated by default because I think this is mthe more expected behaviour - at least from my use cases. But this is your decision.

Ticket can be closed if that issue only appeared for my setup.

many thanks for all your efforts 👍

@d00p

This comment has been minimized.

Copy link
Member

@d00p d00p commented Oct 24, 2019

Ah domain specifc...okay yes, there you are right, we've only updated IPs/Ports...should do the same for domains

@d00p

This comment has been minimized.

Copy link
Member

@d00p d00p commented Oct 24, 2019

But then again only for updaters from 0.10.1 to 0.10.2 - because we cannot know whether people on 0.10.2 already adjusted their settings

@d00p d00p closed this in 90d921e Oct 24, 2019
0.10.x automation moved this from To do to Done Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
0.10.x
  
Done
2 participants
You can’t perform that action at this time.