New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added defaults for the server browser filters #397

Merged
merged 2 commits into from Mar 3, 2017

Conversation

Projects
None yet
3 participants
@IyeOnline
Contributor

IyeOnline commented Mar 1, 2017

The game defaulted the auth filter to "yes" (1) instead of "Any" (0)

Added defaults for the server browser filters
The game defaulted the auth filter to "yes" (1) instead of "Any" (0)

@Barbatos Barbatos self-requested a review Mar 1, 2017

@Barbatos

This comment has been minimized.

Show comment
Hide comment
@Barbatos

Barbatos Mar 1, 2017

Member

@BidyBiddle please actually review the changes before blindly approving them. :) There's a typo in one of the three lines added.

Member

Barbatos commented Mar 1, 2017

@BidyBiddle please actually review the changes before blindly approving them. :) There's a typo in one of the three lines added.

@Barbatos

Barbatos requested changes Mar 1, 2017 edited

Hey @IyeOnline, there's a small typo in your PR, could you please fix it? Thanks!
"ui_borwserShowAccounts" should be "ui_browserShowAccounts"

@Barbatos Barbatos added this to the 4.3.3 milestone Mar 1, 2017

@Barbatos Barbatos self-assigned this Mar 1, 2017

@BidyBiddle

This comment has been minimized.

Show comment
Hide comment
@BidyBiddle

BidyBiddle Mar 1, 2017

Contributor

Indeed hadn't caught that one, stay cool. Should be fixed @IyeOnline :)

Contributor

BidyBiddle commented Mar 1, 2017

Indeed hadn't caught that one, stay cool. Should be fixed @IyeOnline :)

@BidyBiddle BidyBiddle self-requested a review Mar 1, 2017

@IyeOnline

This comment has been minimized.

Show comment
Hide comment
@IyeOnline

IyeOnline Mar 2, 2017

Contributor

i guess thats what you get for actually typing instead of copy pasting xD

Contributor

IyeOnline commented Mar 2, 2017

i guess thats what you get for actually typing instead of copy pasting xD

@Barbatos Barbatos merged commit bc2add8 into FrozenSand:master Mar 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment