Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug inactivity timeout #150

Closed
Titonus opened this issue Feb 22, 2023 · 1 comment
Closed

Bug inactivity timeout #150

Titonus opened this issue Feb 22, 2023 · 1 comment

Comments

@Titonus
Copy link

Titonus commented Feb 22, 2023

FtpServer/src/FubarDev.FtpServer/FtpServerBuilderExtensionsForChecks.cs

Line 37 in edfe7a7

builder.Services.AddSingleton<IFtpConnectionCheck, FtpConnectionIdleCheck>();

It must be AddTransient not AddSingleton, because following connections will be dropped out after the first one expires its timeout.
Another option is review current algorithm or methods for checking inactivity.
@Titonus
Copy link
Author

Titonus commented Feb 22, 2023

#148 (comment)

@Titonus Titonus closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Titonus