From 962b322b28617a7d36c2b066314d8991fd1bf9c8 Mon Sep 17 00:00:00 2001 From: Artem Yurchenko Date: Tue, 9 Apr 2024 22:12:01 -0400 Subject: [PATCH 1/3] rename duplicated tests --- test/smartparens-delete-pair-test.el | 2 +- test/smartparens-elixir-test.el | 2 +- test/smartparens-org-test.el | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/test/smartparens-delete-pair-test.el b/test/smartparens-delete-pair-test.el index eb721929..9c6cf217 100644 --- a/test/smartparens-delete-pair-test.el +++ b/test/smartparens-delete-pair-test.el @@ -13,7 +13,7 @@ (delete-backward-char 1) (should (equal (buffer-string) "\\{"))))) -(ert-deftest sp-test-delete-pair-closing () +(ert-deftest sp-test-delete-pair-opening () (let ((sp-pairs sp--test-basic-pairs)) (sp-test-with-temp-elisp-buffer "\\{|" (smartparens-strict-mode -1) diff --git a/test/smartparens-elixir-test.el b/test/smartparens-elixir-test.el index 7494e862..3fb1b88a 100644 --- a/test/smartparens-elixir-test.el +++ b/test/smartparens-elixir-test.el @@ -118,7 +118,7 @@ end" end" '(:beg 1 :end 87 :op "defmodule" :cl "end" :prefix "" :suffix ""))) -(ert-deftest sp-test-elixir-parse-bodyless-defp-w-keyword-list () +(ert-deftest sp-test-elixir-parse-bodyless-def-w-keyword-list () "Parse bodyless defp correctly with keyword-list body" (sp-test-elixir-parse "|defmodule HelloWorld do def hello diff --git a/test/smartparens-org-test.el b/test/smartparens-org-test.el index 1be6d5a2..aa5f615f 100644 --- a/test/smartparens-org-test.el +++ b/test/smartparens-org-test.el @@ -66,7 +66,7 @@ (execute-kbd-macro "foo /bar") (sp-buffer-equals "foo /bar|/"))) -(ert-deftest sp-test-org-do-not-insert-star-pair-after-word () +(ert-deftest sp-test-org-do-not-insert-slash-pair-after-word () (sp-test-with-temp-buffer "|" (org-mode) (execute-kbd-macro "foo bar/ baz") @@ -98,7 +98,7 @@ (execute-kbd-macro "foo ~bar") (sp-buffer-equals "foo ~bar|~"))) -(ert-deftest sp-test-org-do-not-insert-star-pair-after-word () +(ert-deftest sp-test-org-do-not-insert-tilde-pair-after-word () (sp-test-with-temp-buffer "|" (org-mode) (execute-kbd-macro "foo bar~ baz") @@ -130,7 +130,7 @@ (execute-kbd-macro "foo =bar") (sp-buffer-equals "foo =bar|="))) -(ert-deftest sp-test-org-do-not-insert-star-pair-after-word () +(ert-deftest sp-test-org-do-not-insert-equals-pair-after-word () (sp-test-with-temp-buffer "|" (org-mode) (execute-kbd-macro "foo bar= baz") From 8808729f6a9882ac4a74af244eeb42f69096c961 Mon Sep 17 00:00:00 2001 From: Artem Yurchenko Date: Tue, 9 Apr 2024 23:34:13 -0400 Subject: [PATCH 2/3] fix the latex-mode test the intention is clearly to have to the point in the parentheses --- test/smartparens-latex-test.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/smartparens-latex-test.el b/test/smartparens-latex-test.el index c5ed6ee8..82b9cbe2 100644 --- a/test/smartparens-latex-test.el +++ b/test/smartparens-latex-test.el @@ -22,7 +22,7 @@ (sp-backward-slurp-sexp 2) (sp-buffer-equals "foo ((bar)(baz)|)") (sp-backward-barf-sexp 2) - (sp-buffer-equals "foo (bar)(baz)|()"))) + (sp-buffer-equals "foo (bar)(baz)(|)"))) (ert-deftest sp-test-latex-insert-space-on-backward-slurp-where-necessary () (sp-test-with-temp-buffer "foo bar(baz|)" From 7e72c307d4401126f9c25dc8b8ad11e50130bb13 Mon Sep 17 00:00:00 2001 From: Artem Yurchenko Date: Tue, 9 Apr 2024 23:09:50 -0400 Subject: [PATCH 3/3] add tests for the LaTeX-mode for now, they are just duplicated tests for the latex-mode --- test/smartparens-LaTeX-test.el | 102 +++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 test/smartparens-LaTeX-test.el diff --git a/test/smartparens-LaTeX-test.el b/test/smartparens-LaTeX-test.el new file mode 100644 index 00000000..c77f3777 --- /dev/null +++ b/test/smartparens-LaTeX-test.el @@ -0,0 +1,102 @@ +(require 'smartparens-latex) + +(ert-deftest sp-test-LaTeX-dont-insert-space-on-forward-slurp-where-not-necessary () + (sp-test-with-temp-buffer "foo (|)(bar)(baz)" + (LaTeX-mode) + (sp-forward-slurp-sexp 2) + (sp-buffer-equals "foo (|(bar)(baz))") + (sp-forward-barf-sexp 2) + (sp-buffer-equals "foo (|)(bar)(baz)"))) + +(ert-deftest sp-test-LaTeX-insert-space-on-forward-slurp-where-necessary () + (sp-test-with-temp-buffer "foo (|bar)baz" + (LaTeX-mode) + (sp-forward-slurp-sexp) + (sp-buffer-equals "foo (|bar baz)") + (sp-forward-barf-sexp) + (sp-buffer-equals "foo (|bar) baz"))) + +(ert-deftest sp-test-LaTeX-dont-insert-space-on-backward-slurp-where-not-necessary () + (sp-test-with-temp-buffer "foo (bar)(baz)(|)" + (LaTeX-mode) + (sp-backward-slurp-sexp 2) + (sp-buffer-equals "foo ((bar)(baz)|)") + (sp-backward-barf-sexp 2) + (sp-buffer-equals "foo (bar)(baz)(|)"))) + +(ert-deftest sp-test-LaTeX-insert-space-on-backward-slurp-where-necessary () + (sp-test-with-temp-buffer "foo bar(baz|)" + (LaTeX-mode) + (sp-backward-slurp-sexp) + (sp-buffer-equals "foo (bar baz|)") + (sp-backward-barf-sexp) + (sp-buffer-equals "foo bar (baz|)"))) + +(ert-deftest sp-test-LaTeX-navigate-single-quote-pair-backwards-at-opener () + (sp-test-with-temp-buffer "\\foo{bar} `|foo bar'baz'" + (LaTeX-mode) + (should (equal (sp-get-thing t) + '(:beg 11 :end 24 :op "`" :cl "'" :prefix "" :suffix ""))))) + +(ert-deftest sp-test-LaTeX-navigate-single-quote-pair-backwards-at-closer () + (sp-test-with-temp-buffer "\\foo{bar} `foo bar'baz'|" + (LaTeX-mode) + (should (equal (sp-get-thing t) + '(:beg 11 :end 24 :op "`" :cl "'" :prefix "" :suffix ""))))) + +;; SKIP: +;; (ert-deftest sp-test-LaTeX-navigate-single-quote-pair-backwards-at-contraction () +;; (sp-test-with-temp-buffer "\\foo{bar} `foo bar'|bar'" +;; (LaTeX-mode) +;; (should (equal (sp-get-thing t) +;; '(:beg 16 :end 19 :op "" :cl "" :prefix "" :suffix ""))))) + +;; #820 +(ert-deftest sp-test-LaTeX-do-not-fix-closing-delimiter-on-insert-when-inserting-more-than-one-char () + "Some electric keys sometimes insert more than one character. +In this case the behaviour is more complicated and we shouldn't +try to fix the buffer. + +For example quote in LaTeX inserts two backticks which messes up +with the search logic (if inserted one-by-one they would pair by +thesmeves and would not break unrelated pair)" + (sp-test-with-temp-buffer "quote: | $f' = 0$" + (LaTeX-mode) + (execute-kbd-macro "\"") + (sp-buffer-equals "quote: ``|'' $f' = 0$"))) + +;; #990 +(ert-deftest sp-test-LaTeX-do-parse-string-quotes-outside-math () + (sp-test-with-temp-buffer "foo ``bar''| baz" + (LaTeX-mode) + (sp-backward-sexp) + (sp-buffer-equals "foo |``bar'' baz"))) + +;; #990 +(ert-deftest sp-test-LaTeX-dont-parse-string-quotes-in-math () + (sp-test-with-temp-buffer "$foo ``bar''| baz$" + (LaTeX-mode) + (sp-backward-sexp) + (sp-buffer-equals "$foo ``|bar'' baz$"))) + +;; #990 +(ert-deftest sp-test-LaTeX-do-pair-string-quotes-outside-math () + (sp-test-with-temp-buffer "foo | baz" + (LaTeX-mode) + (execute-kbd-macro "``") + (sp-buffer-equals "foo ``|'' baz"))) + +;; #990 +(ert-deftest sp-test-LaTeX-dont-pair-string-quotes-in-math () + (sp-test-with-temp-buffer "$foo | baz$" + (LaTeX-mode) + (execute-kbd-macro "``") + (sp-buffer-equals "$foo ``| baz$"))) + +;; #834 +(ert-deftest sp-test-LaTeX-wrap-with-trigger () + "A region should be wrapped with a pair if trigger key is pressed." + (sp-test-with-temp-buffer "foo Mbar baz| bam" + (LaTeX-mode) + (execute-kbd-macro "\"") + (sp-buffer-equals "foo ``bar baz''| bam")))