Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Provider #54

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Update Provider #54

merged 1 commit into from
Nov 8, 2021

Conversation

AlicanC
Copy link
Contributor

@AlicanC AlicanC commented Nov 5, 2021 •
edited
Loading

  • Added new get methods introduced in fuel-core
  • Fixed TransactionRequest

@AlicanC AlicanC self-assigned this Nov 5, 2021
@AlicanC AlicanC force-pushed the update-provider branch 2 times, most recently from 85aa275 to 6593693 Compare November 8, 2021 15:11
@AlicanC
Copy link
Contributor Author

AlicanC commented Nov 8, 2021

@adlerjohn

This is how a TransactionRequest looks like now:
https://github.com/FuelLabs/fuels-ts/pull/54/files#diff-5c40d6e7958ffe053b451110b6330c320ad20e3d67c044c0b5b890f3d7321a89R8-R33

Compared to a Transaction, I just:

  • Omitted lengths and counts (scriptLength, inputsCount, bytecodeLength, etc) because the SDK can calculate those from other fields.
  • Omitted receiptsRoot and set it to 0x0000000000000000000000000000000000000000000000000000000000000000.

Inspired from here:
https://github.com/FuelLabs/fuel-tx/blob/b8e762489a1cce9cbebbe64d2aaea32d9b56fea5/src/transaction.rs#L112-L162

QuinnLee
QuinnLee approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@QuinnLee QuinnLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlicanC AlicanC merged commit 4396d1e into master Nov 8, 2021
@AlicanC AlicanC deleted the update-provider branch November 8, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuinnLee QuinnLee QuinnLee approved these changes

@adlerjohn adlerjohn Awaiting requested review from adlerjohn

Assignees

@AlicanC AlicanC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlicanC @QuinnLee