Changes panic to revert in sway-lib-std
#1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
reviewed
May 7, 2022
nfurfaro
reviewed
May 7, 2022
…were mentioned and changed 'panic' to 'revert' in Examples
adlerjohn
added
the
breaking
|
Looks like the |
|
Nice contribution! Thank you! The CI (continuous integration -- our testing infrastructure) is currently failing for these changes. Here is what you need to do to fix them: |
sezna
approved these changes
May 8, 2022
There was a problem hiding this comment.
Looks good to me, will wait for a once-over from @adlerjohn before merging 😄 thanks for the contribution!
adlerjohn
approved these changes
May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1470
I changed every instance of
panictorevertand some of the comments. I also ran the test suite on a node and made corrections to the test where applicable.