Parse __ptr[T] and __slice[T]
#4522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlicanC
force-pushed
the
jc/typed-ptr-parsing
branch
from
385e04e
to
65ca1e0
Compare
AlicanC
added
the
compiler: frontend
IGI-111
reviewed
May 2, 2023
IGI-111
added
breaking
IGI-111
approved these changes
May 4, 2023
tritao
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just parsing for typed pointers and slices. Went with long and distinct names for now but we could change them to something like
&Tand&[T]in the future.The only tricky part was this, where I had to fix how we parse
implitems: https://github.com/FuelLabs/sway/pull/4522/files#diff-51ff5479fa74960c097173172a99b15be1dbd4d858960e619eca1ae740816552