From d704f727de7edb7a714d72474d565f5c1aaad0fd Mon Sep 17 00:00:00 2001 From: Maxime Mangel Date: Fri, 31 Aug 2018 14:28:01 +0200 Subject: [PATCH] Fix Tabs.tab option builder was missing `CustomClass`, `Modifiers` --- src/Fulma/Components/Tabs.fs | 5 ++++- src/Fulma/Fulma.fsproj | 2 +- src/Fulma/RELEASE_NOTES.md | 4 ++++ templates/Content/.gitignore | 1 + templates/Content/.paket/Paket.Restore.targets | 9 ++++++--- 5 files changed, 16 insertions(+), 5 deletions(-) diff --git a/src/Fulma/Components/Tabs.fs b/src/Fulma/Components/Tabs.fs index cc96b060..4a17db2b 100644 --- a/src/Fulma/Components/Tabs.fs +++ b/src/Fulma/Components/Tabs.fs @@ -118,6 +118,9 @@ module Tabs = | Tab.Modifiers modifiers -> { result with Modifiers = modifiers |> Modifier.parseModifiers } let opts = options |> List.fold parseOptions Tab.Options.Empty - let classes = classList [ Classes.State.IsActive, opts.IsActive ] :> IHTMLProp + let classes = Helpers.classes + "" + ( opts.CustomClass::opts.Modifiers ) + [ Classes.State.IsActive, opts.IsActive ] li (classes::opts.Props) children diff --git a/src/Fulma/Fulma.fsproj b/src/Fulma/Fulma.fsproj index 49daa8f9..ebb09703 100644 --- a/src/Fulma/Fulma.fsproj +++ b/src/Fulma/Fulma.fsproj @@ -8,7 +8,7 @@ https://github.com/MangelMaxime/Fulma fable;elm;fsharp;bulma Maxime Mangel - 1.0.0-beta-025 + 1.0.0-beta-026 netstandard1.6 diff --git a/src/Fulma/RELEASE_NOTES.md b/src/Fulma/RELEASE_NOTES.md index d73039e6..b6e9f1ea 100644 --- a/src/Fulma/RELEASE_NOTES.md +++ b/src/Fulma/RELEASE_NOTES.md @@ -1,3 +1,7 @@ +### 1.0.0-beta-026 + +- Fix Tabs.tab option builder. `CustomClass` and `Modifiers` wasn't added to the generated classes + ### 1.0.0-beta-025 - BREAKING CHANGE: `Menu.item` has been replaced with `Menu.Item.a` and `Menu.Item.li` diff --git a/templates/Content/.gitignore b/templates/Content/.gitignore index a2e68399..32fb23a1 100644 --- a/templates/Content/.gitignore +++ b/templates/Content/.gitignore @@ -1,3 +1,4 @@ +.DS_Store packages/ paket-files/ paket.local diff --git a/templates/Content/.paket/Paket.Restore.targets b/templates/Content/.paket/Paket.Restore.targets index 55292f31..6be03acb 100644 --- a/templates/Content/.paket/Paket.Restore.targets +++ b/templates/Content/.paket/Paket.Restore.targets @@ -72,6 +72,9 @@ true + + true + @@ -93,7 +96,7 @@ $(MSBuildProjectDirectory)\$(MSBuildProjectName).paket.references $(MSBuildProjectDirectory)\paket.references - + false true true @@ -132,11 +135,11 @@ - + - + $([System.String]::Copy('%(PaketReferencesFileLines.Identity)').Split(',')[0]) $([System.String]::Copy('%(PaketReferencesFileLines.Identity)').Split(',')[1])