New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deathhand #153

Merged
merged 43 commits into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@stefanhendriks
Contributor

stefanhendriks commented May 3, 2017

#Works on #13

TODO:

  • add tests for event handlers & subscribers

    • test that when adding aneventSubscriber, the entity itself will also add an eventSubscriber to remove the subscriber.
    • make sure only 1 eventSubscriber is added for destroying/cleaning up the subscriber. (there can be more eventSubscribers for a given eventType
    • test creation/deletion of subscriber and event firing etc.
  • After missile is launched, make sure it has to rebuild again

  • auto rebuild? (deferred to: #162)

  • add some tests?

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 7, 2017

Coverage Status

Coverage decreased (-2.08%) to 80.726% when pulling 431fa86 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 7, 2017

Coverage Status

Coverage decreased (-2.08%) to 80.726% when pulling 431fa86 on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 7, 2017

Coverage Status

Coverage decreased (-2.08%) to 80.726% when pulling 431fa86 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 7, 2017

Coverage Status

Coverage decreased (-2.08%) to 80.726% when pulling 431fa86 on feature/death-hand into 57a46c4 on master.

@stefanhendriks

This comment has been minimized.

Show comment
Hide comment
@stefanhendriks

stefanhendriks Jul 7, 2017

Contributor

@arjenvanderende I am unsure how we wanted to implement this. I am now taking the Projectile implementation, but we had other plans. Lets discuss.

Contributor

stefanhendriks commented Jul 7, 2017

@arjenvanderende I am unsure how we wanted to implement this. I am now taking the Projectile implementation, but we had other plans. Lets discuss.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 7, 2017

Coverage Status

Coverage decreased (-2.4%) to 80.445% when pulling afd1627 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 7, 2017

Coverage Status

Coverage decreased (-2.4%) to 80.445% when pulling afd1627 on feature/death-hand into 57a46c4 on master.

stefanhendriks added some commits Jul 7, 2017

Spawn a projectile from the SuperPower logic
So that we can have different super powers scripted.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 7, 2017

Coverage Status

Coverage decreased (-1.9%) to 80.942% when pulling 7cf11fd on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 7, 2017

Coverage Status

Coverage decreased (-1.9%) to 80.942% when pulling 7cf11fd on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 7, 2017

Coverage Status

Coverage decreased (-1.8%) to 80.993% when pulling 58eebaa on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 7, 2017

Coverage Status

Coverage decreased (-1.8%) to 80.993% when pulling 58eebaa on feature/death-hand into 57a46c4 on master.

stefanhendriks added some commits Jul 11, 2017

Make sure the subscriber is cleaned up appropiately.
- The subscriber for events, which delivers the method to be called on a
certain event, will now be removed explicitly. This entity could be
destroyed by other means, but still remain. Using this explicit
subscription it will mark itself for deletion.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 11, 2017

Coverage Status

Coverage decreased (-2.5%) to 80.275% when pulling 866b43b on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 11, 2017

Coverage Status

Coverage decreased (-2.5%) to 80.275% when pulling 866b43b on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 12, 2017

Coverage Status

Coverage decreased (-1.8%) to 81.037% when pulling ce2f43c on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 12, 2017

Coverage Status

Coverage decreased (-1.8%) to 81.037% when pulling ce2f43c on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 12, 2017

Coverage Status

Coverage decreased (-1.8%) to 81.037% when pulling 3e1fbb5 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 12, 2017

Coverage Status

Coverage decreased (-1.8%) to 81.037% when pulling 3e1fbb5 on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 12, 2017

Coverage Status

Coverage decreased (-1.8%) to 81.037% when pulling e12480a on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 12, 2017

Coverage Status

Coverage decreased (-1.8%) to 81.037% when pulling e12480a on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 12, 2017

Coverage Status

Coverage decreased (-1.8%) to 81.037% when pulling e12480a on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 12, 2017

Coverage Status

Coverage decreased (-1.8%) to 81.037% when pulling e12480a on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 12, 2017

Coverage Status

Coverage decreased (-1.8%) to 81.037% when pulling d1d9eb4 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 12, 2017

Coverage Status

Coverage decreased (-1.8%) to 81.037% when pulling d1d9eb4 on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 18, 2017

Coverage Status

Coverage decreased (-1.7%) to 81.133% when pulling 269e408 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 18, 2017

Coverage Status

Coverage decreased (-1.7%) to 81.133% when pulling 269e408 on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 19, 2017

Coverage Status

Coverage decreased (-2.1%) to 80.661% when pulling 796fc4d on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 19, 2017

Coverage Status

Coverage decreased (-2.1%) to 80.661% when pulling 796fc4d on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 20, 2017

Coverage Status

Coverage decreased (-2.3%) to 80.52% when pulling 545c155 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 20, 2017

Coverage Status

Coverage decreased (-2.3%) to 80.52% when pulling 545c155 on feature/death-hand into 57a46c4 on master.

stefanhendriks added some commits Jul 20, 2017

Move EntityData to own package, and accompany it with SoundData.
- For now, I don't like the location of loading its data within the
EntitiesDataReader yet, nor in EntitiesData itself. But for now follow
path of least resistance
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 22, 2017

Coverage Status

Coverage decreased (-4.08%) to 78.723% when pulling 47b8f58 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 22, 2017

Coverage Status

Coverage decreased (-4.08%) to 78.723% when pulling 47b8f58 on feature/death-hand into 57a46c4 on master.

Improve nuke explosions:
- Performance increase, by only calculating cells that are hit once and
checking entities for each update cycle, using one filter predicate call
(not multiple loops)
- Add smoke effects, that fade out and are further reaching than the
actual explosion (hard-coded for now)
- Add damage, the furter away, the less damage taken
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 23, 2017

Coverage Status

Coverage decreased (-4.3%) to 78.55% when pulling 5ce8766 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 23, 2017

Coverage Status

Coverage decreased (-4.3%) to 78.55% when pulling 5ce8766 on feature/death-hand into 57a46c4 on master.

stefanhendriks added some commits Jul 23, 2017

Add a concept of 'height' to projectiles
- if given a projectile will be launched 'up' and later heads 'down' to
its target. Giving a nice 3d-ish effect. Shadow is just copy of the
image all in black
@stefanhendriks

This comment has been minimized.

Show comment
Hide comment
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 24, 2017

Coverage Status

Coverage decreased (-4.5%) to 78.324% when pulling 10ea20a on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-4.5%) to 78.324% when pulling 10ea20a on feature/death-hand into 57a46c4 on master.

@stefanhendriks stefanhendriks referenced this pull request Jul 24, 2017

Closed

Nuclear Missile (Death hand) #13

11 of 11 tasks complete
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 24, 2017

Coverage Status

Coverage decreased (-4.5%) to 78.256% when pulling a08b09e on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-4.5%) to 78.256% when pulling a08b09e on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 24, 2017

Coverage Status

Coverage decreased (-4.6%) to 78.242% when pulling 8b553b5 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-4.6%) to 78.242% when pulling 8b553b5 on feature/death-hand into 57a46c4 on master.

stefanhendriks added some commits Jul 24, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 24, 2017

Coverage Status

Coverage decreased (-2.5%) to 80.267% when pulling 9fa59a2 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-2.5%) to 80.267% when pulling 9fa59a2 on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 24, 2017

Coverage Status

Coverage decreased (-2.7%) to 80.151% when pulling e6322ff on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-2.7%) to 80.151% when pulling e6322ff on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 24, 2017

Coverage Status

Coverage decreased (-2.4%) to 80.384% when pulling 40b2316 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-2.4%) to 80.384% when pulling 40b2316 on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 24, 2017

Coverage Status

Coverage decreased (-1.9%) to 80.929% when pulling dfb13b5 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-1.9%) to 80.929% when pulling dfb13b5 on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 24, 2017

Coverage Status

Coverage decreased (-1.2%) to 81.601% when pulling e268f76 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 24, 2017

Coverage Status

Coverage decreased (-1.2%) to 81.601% when pulling e268f76 on feature/death-hand into 57a46c4 on master.

stefanhendriks added some commits Jul 28, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 28, 2017

Coverage Status

Coverage decreased (-1.2%) to 81.601% when pulling db072a6 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 28, 2017

Coverage Status

Coverage decreased (-1.2%) to 81.601% when pulling db072a6 on feature/death-hand into 57a46c4 on master.

@stefanhendriks stefanhendriks changed the title from [WIP] Deathhand to Deathhand Jul 28, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 28, 2017

Coverage Status

Coverage decreased (-1.2%) to 81.612% when pulling f08817b on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 28, 2017

Coverage Status

Coverage decreased (-1.2%) to 81.612% when pulling f08817b on feature/death-hand into 57a46c4 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jul 28, 2017

Coverage Status

Coverage decreased (-1.3%) to 81.543% when pulling 5661618 on feature/death-hand into 57a46c4 on master.

coveralls commented Jul 28, 2017

Coverage Status

Coverage decreased (-1.3%) to 81.543% when pulling 5661618 on feature/death-hand into 57a46c4 on master.

@stefanhendriks stefanhendriks merged commit 11de065 into master Jul 28, 2017

3 of 4 checks passed

coverage/coveralls Coverage decreased (-1.3%) to 81.543%
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@stefanhendriks stefanhendriks deleted the feature/death-hand branch Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment