Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl to install instructions [required for fresh Ubuntu 22.04] #1684

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

CoronelBuendia
Copy link
Contributor

Linked Issues

Closes #1641

Description

Interface Changes

Checklist

I confirm that I have completed the following checks:

  • Tests run locally and pass pytest tests --reactor
  • Code quality checks run locally and pass flake8 and black .
  • Documentation built locally and checked sphinx-build -W documentation/source documentation/build

@CoronelBuendia CoronelBuendia requested a review from a team as a code owner November 30, 2022 14:31
Copy link
Contributor

@je-cook je-cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely optional but this is probably more descriptive

documentation/source/installation.rst Outdated Show resolved Hide resolved
Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

⚠️ Warning Report

Found 0 new warnings, 0 fixed warnings. 🎉

@codecov-commenter
Copy link

Codecov Report

Merging #1684 (689e29d) into develop (b9b92a5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1684   +/-   ##
========================================
  Coverage    74.57%   74.57%           
========================================
  Files          162      162           
  Lines        19378    19378           
========================================
  Hits         14451    14451           
  Misses        4927     4927           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@je-cook je-cook merged commit 0da0a4c into develop Dec 1, 2022
@je-cook je-cook deleted the matti/add-curl-install branch December 1, 2022 07:40
@je-cook je-cook self-assigned this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 22 Doesn't include Curl and this is missing on Installation Guide
3 participants