Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The library does not check the situation if signature algorithm is defined but no signature is provided #2

Closed
dmak opened this issue Jan 30, 2018 · 2 comments
Assignees

Comments

@dmak
Copy link

@dmak dmak commented Jan 30, 2018

Please doublecheck this is a valid issue. According to JWS §4.1.1 "alg" Header Parameter MUST be present and MUST be understood and processed by implementations.

In my opinion that means that if "alg" is not "none", then signature must be present and verified. Attached
JwtTest.java.txt demonstrates the problem.

robotdan added a commit that referenced this issue Jan 30, 2018
@robotdan

This comment has been minimized.

Copy link
Member

@robotdan robotdan commented Jan 30, 2018

Hi @dmak ,

You are correct, this is not the intended behavior, I thought I had a test that covered this scenario. I added your test and resolved the issue.

Thanks for pointing this out.

@robotdan robotdan self-assigned this Jan 30, 2018
@robotdan

This comment has been minimized.

Copy link
Member

@robotdan robotdan commented Jan 30, 2018

Resolved in version 1.3.0

@robotdan robotdan closed this Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.