New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add String.prototype.includes() #2071

Closed
MatayoshiMariano opened this Issue Nov 4, 2015 · 14 comments

Comments

Projects
None yet
@williamboman

This comment has been minimized.

Show comment
Hide comment

+1

@jsturgis

This comment has been minimized.

Show comment
Hide comment

jsturgis commented Mar 1, 2016

+1

@enterprisey

This comment has been minimized.

Show comment
Hide comment

+1

@wmill

This comment has been minimized.

Show comment
Hide comment

wmill commented Sep 19, 2016

+1

@jeffmcmahan

This comment has been minimized.

Show comment
Hide comment
@jeffmcmahan

jeffmcmahan Nov 13, 2016

Just noticed caniuse does link to https://kangax.github.io/compat-table/es6/#test-String.prototype_methods_String.prototype.includes, but it provides said link in documenting the non-existent "String#contains" and "Array#contains" methods.

See: http://caniuse.com/#search=.contains

Just noticed caniuse does link to https://kangax.github.io/compat-table/es6/#test-String.prototype_methods_String.prototype.includes, but it provides said link in documenting the non-existent "String#contains" and "Array#contains" methods.

See: http://caniuse.com/#search=.contains

@hovissimo

This comment has been minimized.

Show comment
Hide comment
@hovissimo

hovissimo Apr 14, 2017

While Github added a lovely thumbs-up voting button, it says explicitly in the projects documentation that '+1' comments should be used to support a feature. Further, it's apparent that those comments are being automatically counted and shown here: http://caniuse.com/issue-list/

If you want to show your support for this issue, please use the old +1 comments.

While Github added a lovely thumbs-up voting button, it says explicitly in the projects documentation that '+1' comments should be used to support a feature. Further, it's apparent that those comments are being automatically counted and shown here: http://caniuse.com/issue-list/

If you want to show your support for this issue, please use the old +1 comments.

@hovissimo

This comment has been minimized.

Show comment
Hide comment

+1

@cherukumilli

This comment has been minimized.

Show comment
Hide comment

+1

@ryb73

This comment has been minimized.

Show comment
Hide comment

ryb73 commented May 8, 2017

+1

@Nateowami

This comment has been minimized.

Show comment
Hide comment

+1

@Offirmo

This comment has been minimized.

Show comment
Hide comment

Offirmo commented Nov 10, 2017

+1

@andyfry01

This comment has been minimized.

Show comment
Hide comment

+1

@Fyrd

This comment has been minimized.

Show comment
Hide comment
Owner

Fyrd commented Jan 3, 2018

@Fyrd Fyrd closed this Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment