Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontFace API: display incorrect for Edge (Chromium) #5301

Closed
Nooshu opened this issue Feb 26, 2020 · 4 comments
Closed

FontFace API: display incorrect for Edge (Chromium) #5301

Nooshu opened this issue Feb 26, 2020 · 4 comments

Comments

@Nooshu
Copy link

@Nooshu Nooshu commented Feb 26, 2020

Current data says it isn't supported: https://caniuse.com/#feat=mdn-api_fontface_display

But tests here and testing the test page in Chromium 80 shows there is a display property in the FontFace.

Related tweets here and here.

@vinyldarkscratch

This comment has been minimized.

Copy link
Contributor

@vinyldarkscratch vinyldarkscratch commented Feb 27, 2020

It appears that the data comes from MDN browser-compat-data (BCD) for that particular feature, and on the MDN web docs, support is properly marked (see https://wiki.developer.mozilla.org/en-US/docs/Web/API/FontFace). We just recently performed a mass data mirroring of Chrome to Edge in BCD, so it's possible that the data has yet to update on CanIUse. Either that, or maybe ranged values from BCD aren't implemented in CanIUse?

@Fyrd, can you comment on ranged value support for the BCD data?

@Fyrd

This comment has been minimized.

Copy link
Owner

@Fyrd Fyrd commented Feb 27, 2020

Yup, looks like ranged value support wasn't properly implemented on the caniuse side. I did have some code specific to the "≤37" Android versions but that was pretty hard-coded. Have just pushed a change that hopefully supports version ranges more correctly, see https://caniuse.com/#feat=mdn-api_fontface_display

@Fyrd

This comment has been minimized.

Copy link
Owner

@Fyrd Fyrd commented Feb 27, 2020

Thanks for discovering the cause of the discrepancy, @vinyldarkscratch !

@Nooshu

This comment has been minimized.

Copy link
Author

@Nooshu Nooshu commented Feb 27, 2020

Screenshot 2020-02-27 at 09 02 21

Can now see the fix. Thanks for the prompt response!

@Nooshu Nooshu closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.