Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Converter] Change same name section renaming #312

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

mpsonntag
Copy link
Contributor

@mpsonntag mpsonntag commented Nov 16, 2018

Previously all same named odml.Sections within a document were indexed upon conversion. With these changes, only same named odml.Sections that reside on the same level are indexed.

Closes #289.

Closes G-Node#289

Previously all same named odml.Sections within a
document got indexed upon conversion. With these
changes, only same named odml.Sections that reside
on the same level are indexed.
@coveralls
Copy link

coveralls commented Nov 16, 2018

Coverage Status

Coverage increased (+0.008%) to 77.967% when pulling 76e908a on mpsonntag:convNaming into 6c86f9a on G-Node:master.

Copy link
Member

@jgrewe jgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JuliaSprenger
Copy link
Contributor

Tested it and it works.

@JuliaSprenger JuliaSprenger merged commit 25330df into G-Node:master Nov 16, 2018
@mpsonntag mpsonntag deleted the convNaming branch November 19, 2018 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants