Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pfam database is outdated #5

Open
Jidgdoi opened this issue Jun 26, 2020 · 5 comments
Open

Pfam database is outdated #5

Jidgdoi opened this issue Jun 26, 2020 · 5 comments

Comments

@Jidgdoi
Copy link

@Jidgdoi Jidgdoi commented Jun 26, 2020

Hi,

Your "hgnc2pfam.rdb" is completely outdated, and so all lollipops mutations don't match correctly.
It would be nice to update it, or in a more reliable and sustainable way, permit the user to query his own database or directly the Pfam website.

Otherwise, you did a nice and beautiful job to build this library !

Hope this message will reach you.

A fellow researcher.

@phoeguo
Copy link
Contributor

@phoeguo phoeguo commented Jul 6, 2020

Thank you for the suggestions. We will work on it shortly.

@Nitin123-4
Copy link

@Nitin123-4 Nitin123-4 commented Aug 10, 2020

Any update on this?

@phoeguo
Copy link
Contributor

@phoeguo phoeguo commented Aug 25, 2020

I have updated Pfam (v33.1) and UniProt (date: 2020-08-24) to latest version. Please update the package through GitHub and check the domain mapping.

Also, could you please teach me which gene is different from this package and cbioportal?

I will add some examples about how to retrieve or create domain mappings soon.

@Nitin123-4
Copy link

@Nitin123-4 Nitin123-4 commented Aug 25, 2020

Thanks for the update.

@Jidgdoi
Copy link
Author

@Jidgdoi Jidgdoi commented Aug 25, 2020

Many thanks for the update.
The gene PIM1 was different, but with your update you fixed it. I didn't check for further genes but if I find some, I'll let you know.

I will add some examples about how to retrieve or create domain mappings soon.

This is a good point, I saw your "prepare_data" folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.