Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix POD links, declare non-core prereqs #1

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix POD links, declare non-core prereqs #1

merged 1 commit into from
Nov 16, 2022

Conversation

mjgardner
Copy link
Contributor

I noted that one of the POD links to the GitHub repo was incorrect, so I fixed that and dutifully added an author test (which can be run with make authortest). Note that checking HTTPS scheme URLs and uninstalled modules via CPAN Meta DB requires the installation of Net::SSLeay and IO::Socket::SSL; I've opened trwyant/perl-Test-Pod-LinkCheck-Lite#2 to get that resolved.

That led me down a rabbit hole of making sure this could build, test, and install on Perl 5.10 as declared in the Makefile.PL. There were a couple of issues:

  1. URL links in POD didn't gain support for displaying text instead of the bare URL until Perl 5.12. So I adjusted the POD to use unlinked text with the links adjacent.
  2. Some core Perl module dependencies either weren't core at that time (JSON::PP) or lacked features (File::Path's make_path function, version's declare method). So I added explicit version requirements for both that contain the required functions.

Also, just for completeness' sake, I adjusted the Makefile.PL to skip the META_MERGE Makefile argument on older versions of ExtUtils::MakeMaker.

I noted that one of the POD links to the GitHub repo was incorrect, so I fixed that and dutifully added an author test (which can be run with `make authortest`). Note that checking HTTPS scheme URLs and uninstalled modules via CPAN Meta DB requires the installation of Net::SSLeay and IO::Socket::SSL; I've opened @trwyant/perl-Test-Pod-LinkCheck-Lite#2 to get that resolved.

That led me down a rabbit hole of making sure this could build, test, and install on Perl 5.10 as declared in the Makefile.PL. There were a couple issues:

1. URL links in POD didn't gain support for displaying text instead of the bare URL until Perl 5.12. So I adjusted the POD to use unlinked text with the links adjacent.
2. Some core Perl module dependencies either weren't core at that time (JSON::PP) or lacked features (File::Path's `make_path` function, version's `declare` method). So I added explicit version requirements for both that contain the required functions.

Also, just for completeness' sake, I adjusted the Makefile.PL to skip the META_MERGE Makefile argument on older versions of ExtUtils::MakeMaker.
@G4Vi
Copy link
Owner

G4Vi commented Nov 16, 2022

Thank you. Accepting 5.10+ was coincidental from copy paste, but allowing oldest possible Perl with // to build APPerl is great! I'll add the author test and some 5.10 checks to the actions script later today.

@G4Vi G4Vi merged commit ae907e5 into G4Vi:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants