Fix POD links, declare non-core prereqs#1
Merged
Conversation
I noted that one of the POD links to the GitHub repo was incorrect, so I fixed that and dutifully added an author test (which can be run with `make authortest`). Note that checking HTTPS scheme URLs and uninstalled modules via CPAN Meta DB requires the installation of Net::SSLeay and IO::Socket::SSL; I've opened @trwyant/perl-Test-Pod-LinkCheck-Lite#2 to get that resolved. That led me down a rabbit hole of making sure this could build, test, and install on Perl 5.10 as declared in the Makefile.PL. There were a couple issues: 1. URL links in POD didn't gain support for displaying text instead of the bare URL until Perl 5.12. So I adjusted the POD to use unlinked text with the links adjacent. 2. Some core Perl module dependencies either weren't core at that time (JSON::PP) or lacked features (File::Path's `make_path` function, version's `declare` method). So I added explicit version requirements for both that contain the required functions. Also, just for completeness' sake, I adjusted the Makefile.PL to skip the META_MERGE Makefile argument on older versions of ExtUtils::MakeMaker.
Owner
|
Thank you. Accepting 5.10+ was coincidental from copy paste, but allowing oldest possible Perl with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noted that one of the POD links to the GitHub repo was incorrect, so I fixed that and dutifully added an author test (which can be run with
make authortest). Note that checking HTTPS scheme URLs and uninstalled modules via CPAN Meta DB requires the installation of Net::SSLeay and IO::Socket::SSL; I've opened trwyant/perl-Test-Pod-LinkCheck-Lite#2 to get that resolved.That led me down a rabbit hole of making sure this could build, test, and install on Perl 5.10 as declared in the Makefile.PL. There were a couple of issues:
make_pathfunction, version'sdeclaremethod). So I added explicit version requirements for both that contain the required functions.Also, just for completeness' sake, I adjusted the Makefile.PL to skip the META_MERGE Makefile argument on older versions of ExtUtils::MakeMaker.