Skip to content

Conversation

per1234
Copy link

@per1234 per1234 commented Nov 5, 2018

Previously, compilation would fail:

ESP8266-Remote-Message-Board-master\ESP8266_MAX7219_Message_Board_AP.ino\ESP8266_MAX7219_Message_Board_AP.ino.ino: In function 'void setup()':

ESP8266_MAX7219_Message_Board_AP.ino:71:17: error: 'GetMEssage' was not declared in this scope

   server.on("/",GetMEssage);

                 ^

Fixes https://github.com/G6EJD/ESP8266-Remote-Message-Board/issues/4

CC: @LenK13

Previously, compilation would fail:

ESP8266-Remote-Message-Board-master\ESP8266_MAX7219_Message_Board_AP.ino\ESP8266_MAX7219_Message_Board_AP.ino.ino: In function 'void setup()':

ESP8266_MAX7219_Message_Board_AP.ino:71:17: error: 'GetMEssage' was not declared in this scope

   server.on("/",GetMEssage);

                 ^
@G6EJD G6EJD closed this Nov 5, 2018
@per1234
Copy link
Author

per1234 commented Nov 5, 2018

Duplicated by:

Ewww... You definitely need to work on your Git skills @G6EJD.

@G6EJD
Copy link
Owner

G6EJD commented Nov 5, 2018

Is it working now?

@per1234
Copy link
Author

per1234 commented Nov 5, 2018

It's too much work for me to check what you did because of the way you did it.

With my pull request, you have a nice diff that clearly shows what I changed and a commit message that explains why this was done. The change was done in a single atomic commit.

You don't need to upload the whole file with a new name and then delete the old file just to change a single character. In addition to being very inefficient, that also makes the diff and development history impossible to follow.

@G6EJD
Copy link
Owner

G6EJD commented Nov 5, 2018

So changing E to e was too much work, perhaps the code is not good enough to meet your exacting standards, you could write your own variant and I look forward to seeing published for criticism in minute detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants