-
Notifications
You must be signed in to change notification settings - Fork 20
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixed concurrentqueue compilation bug on gcc 4.9.1
- Loading branch information
Showing
1 changed file
with
30 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be7bda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've committed a fix for the same bug on the master. See the issue and the Stack Overflow question it spawned.
be7bda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet, thanks for the explanation!
I had to make other modifications to concurrentqueue to get it to compile on gcc 4.7:
c67c60f (+ 0cdb3b9)
be7bda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. I'll work in some fixes for g++ 4.7 too soon, I just didn't have that version installed to test with, sorry. Don't be shy about opening issues on my repo about this stuff :-)
be7bda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a commit to the master that should fix the issues you were having with g++ 4.7. Cheers!
be7bda8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice!