fix(flow-chat): improve Shift+Tab input exclusion and remove redundant handler#829
Merged
Merged
Conversation
…t handler - Extend document-level Shift+Tab exclusion to cover INPUT, SELECT, and contentEditable elements, not just TEXTAREA, preventing unintended mode cycling when typing in any form field - Remove redundant Shift+Tab handler from textarea React onKeyDown since the document listener handles it with proper exclusion - Remove unnecessary comment explaining what the code already expresses
…ling The textarea handler and document listener serve different purposes: - Textarea handler: Shift+Tab in the editable chat input → cycle mode - Document listener: Shift+Tab when input is collapsed → cycle mode (with TEXTAREA exclusion to prevent double-fire) Removing the textarea handler meant Shift+Tab in the expanded textarea would be consumed by the document listener instead, which is less direct and breaks the expected UX of Tab-based mode switching while typing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INPUT,SELECT, andcontentEditableelements — not justTEXTAREA— preventing unintended agent mode cycling while typing in any form fieldonKeyDownsince the document listener already handles it with proper exclusionTest plan