Skip to content

fix(flow-chat): improve Shift+Tab input exclusion and remove redundant handler #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GCWing merged 2 commits into from
May 22, 2026
Merged

fix(flow-chat): improve Shift+Tab input exclusion and remove redundant handler #829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7756865
fix(flow-chat): improve Shift+Tab input exclusion and remove redundan…
jarvis24young May 21, 2026
29f0def
fix(flow-chat): restore textarea Shift+Tab handler for agent mode cyc…
jarvis24young May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/mobile-web/src/pages/ChatPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2419,9 +2419,9 @@ const ChatPage: React.FC<ChatPageProps> = ({ sessionMgr, sessionId, sessionName,
useEffect(() => {
const onKeyDown = (e: KeyboardEvent) => {
if (e.key === 'Tab' && e.shiftKey) {
// Skip when the textarea is focused — its own React handler already fired.
const tag = (e.target as HTMLElement)?.tagName;
if (tag === 'TEXTAREA') return;
const target = e.target as HTMLElement;
const tag = target?.tagName;
if (tag === 'INPUT' || tag === 'TEXTAREA' || tag === 'SELECT' || target?.isContentEditable) return;
e.preventDefault();
cycleAgentModeRef.current();
}
Expand Down
1 change: 0 additions & 1 deletion src/web-ui/src/flow_chat/components/ChatInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2057,7 +2057,6 @@ export const ChatInput: React.FC<ChatInputProps> = ({
e.preventDefault();
e.stopPropagation();

// Dismiss slash command if open
if (slashCommandState.isActive) {
setSlashCommandState({ isActive: false, kind: 'modes', query: '', selectedIndex: 0 });
dispatchInput({ type: 'CLEAR_VALUE' });
Expand Down
Loading