Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters Added for speaker #108

Merged
merged 10 commits into from Oct 7, 2019

Conversation

@pAditya198
Copy link
Contributor

commented Oct 1, 2019

When None of the Filters are selected :

Screenshot (150)

When Machine Learning is Selected as Filter :

Screenshot (151)

When Mobile is Selected as Filter :

Screenshot (152)

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

Schedule Component Also Initialized
linked with speakers firebase

With dummy_data :

Screenshot (153)

With data :

Screenshot (154)

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

@samagragupta @aashutoshrathi Please review

Also Some UI fixes needed.

related to issue #81

@aashutoshrathi aashutoshrathi requested a review from parth181195 Oct 2, 2019
Copy link
Member

left a comment

A few changes are here.
@rossoskull @samagragupta Tell more about styling

Copy link
Member

left a comment

Make a border around the filter buttons.

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Instead of button I've used Checkbox they look more classic and also less variables are used.
Some screenshot are provided below as an example of multiple checks.

Screenshot (156)

Screenshot (157)

Screenshot (158)

Screenshot (159)

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

Review changes are also fixed @aashutoshrathi

Copy link
Member

left a comment

Add a schedule entry in the navbar which will only be shown when the show is true in Firebase.
Also, the elements are not centered properly in Schedule element.

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

@aashutoshrathi should I create a new model for schedule because here I'm using the existing data from speakers

Copy link
Member

left a comment

Make the colour of the checkbox: #00aaf5
Shift the content of the Schedule page at the centre.

@AmanRaj1608

This comment has been minimized.

Copy link
Contributor

commented Oct 3, 2019

@samagragupta @aashutoshrathi
Is this schedule UI okay pAditya198#7

@aashutoshrathi

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

@samagragupta Check once more, we will merge it then

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

@samagragupta @aashutoshrathi
Is this schedule UI okay pAditya198#7

@samagragupta @aashutoshrathi suggest UI changes or should I just merge this commit.

@parth181195

This comment has been minimized.

Copy link
Collaborator

commented Oct 7, 2019

can nu finish the change @aashutoshrathi has requested so i can merge this in master

@parth181195 parth181195 merged commit fb368c7 into GDG-GANDHINAGAR:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.