Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page2 #36

Merged
merged 11 commits into from Sep 2, 2019

Conversation

@pAditya198
Copy link
Contributor

commented Sep 1, 2019

Screenshot (84)

Resolved issue #33 also fixed x-overflow on this page.
Padding issue fixed.

pAditya198 added 5 commits Sep 1, 2019
@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2019

pAditya198 added 2 commits Sep 1, 2019
@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2019

Screenshot (85)

resolved issue #35

@parth181195 @aashutoshrathi @samagragupta please review

@samagragupta
Copy link
Member

left a comment

Also, remove overflow-x of speaker card.

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

Okay I'll take care about that

@samagragupta
Copy link
Member

left a comment

Use this (#36 (comment)) in the Subscription section.

<div class="col-xs-12 col-md-12" style='height: max-content;'>
<br>
<div class="sub-title" style='line-height:50px;font-size: 2em'>
Contact US

This comment has been minimized.

Copy link
@aashutoshrathi

This comment has been minimized.

Copy link
@pAditya198

pAditya198 Sep 2, 2019

Author Contributor

fixed

@aashutoshrathi
Copy link
Member

left a comment

Also please give space between icons

gdggandhinagar@gmail.com
</div>
<div class="sub-title" style='line-height:70px;font-size: 2.2em'>
Subscribe to Us for Updates

This comment has been minimized.

Copy link
@aashutoshrathi

aashutoshrathi Sep 2, 2019

Member

Subscribe for Updates

This comment has been minimized.

Copy link
@pAditya198

pAditya198 Sep 2, 2019

Author Contributor

fixed

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

Screenshot (87)

speaker dialog overflow-x fixed

Screenshot (88)

Contact Us fixed

@aashutoshrathi
Copy link
Member

left a comment

Few changes required

Get notified about important conference updates
<div class="col-xs-12 col-md-12" style='height: max-content;'>
<br>
<div class="sub-title" style='line-height:50px;font-size: 2em'>

This comment has been minimized.

Copy link
@aashutoshrathi

aashutoshrathi Sep 2, 2019

Member

Make this bold

This comment has been minimized.

Copy link
@pAditya198

pAditya198 Sep 2, 2019

Author Contributor

class?

gdggandhinagar@gmail.com
</div>
<div class="sub-title" style='line-height:70px;font-size: 2.2em'>
Subscribe for Updates

This comment has been minimized.

Copy link
@aashutoshrathi

aashutoshrathi Sep 2, 2019

Member

Also, make this bold

Contact Us
</div>
<div class="sub-title" style='line-height:70px;font-size: 1.4em'>
gdggandhinagar@gmail.com

This comment has been minimized.

Copy link
@aashutoshrathi

aashutoshrathi Sep 2, 2019

Member

Make it clickable.
and href="mailto:$email"

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

Screenshot (89)

@aashutoshrathi aashutoshrathi merged commit 18fab32 into GDG-GANDHINAGAR:master Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.