Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy data to environment.ts and remove it from util file #41

Merged
merged 2 commits into from Sep 2, 2019

Conversation

@thepushkarp
Copy link
Member

commented Sep 2, 2019

@aashutoshrathi I've moved the config from util to environment and changed it to dummy data.

@thepushkarp thepushkarp force-pushed the thepushkarp:firebase branch from f82ae9c to 63a055b Sep 2, 2019

@aashutoshrathi
Copy link
Member

left a comment

Do this changes in environment.prod.ts instead of this one

@thepushkarp

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

@aashutoshrathi I've made the changes to environment.prod and reverted environment to using util file.

@thepushkarp thepushkarp force-pushed the thepushkarp:firebase branch from f36f4c9 to 5d5da5e Sep 2, 2019

@aashutoshrathi
Copy link
Member

left a comment

LGTM now.
please start filling real data on firebase

@aashutoshrathi aashutoshrathi merged commit c4ca119 into GDG-GANDHINAGAR:master Sep 2, 2019

@thepushkarp thepushkarp deleted the thepushkarp:firebase branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.