Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rockstar Speakers #54

Closed
wants to merge 27 commits into from

Conversation

@pAditya198
Copy link
Contributor

commented Sep 4, 2019

Screenshot (92)

Previous Speakers have been added to the home-page

pAditya198 added 15 commits Sep 1, 2019
@aashutoshrathi
Copy link
Member

left a comment

Why have you hardcoded this?

@aashutoshrathi

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Also, resolve conflicts.

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

changing previous speakers from assests will be more easier than using firebase.
I think this way is better bacause we are only displaying profile image.

Also Resolved Conflicts.

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Also Fixed Overflow in About page

@aashutoshrathi

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Conflicts again.

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

@aashutoshrathi resolved conflicts

pAditya198 added 3 commits Sep 5, 2019
@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

@aashutoshrathi merge this PR I've fixed footer for mobile view and also fixed assets on speaker page and team page.

@pAditya198 pAditya198 closed this Sep 5, 2019

@aashutoshrathi

This comment has been minimized.

Copy link
Member

commented Sep 5, 2019

@pAditya198 If there is anything in this PR that is missing please raise a new PR for the same.

@pAditya198

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

I'm working on login page if there are any such changes i'll add it to that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.