Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team page completed #8

Open
wants to merge 5 commits into
base: home-page
from

Conversation

@pAditya198
Copy link

commented Aug 12, 2019

Screenshot (72)

@aashutoshrathi
Copy link
Member

left a comment

It would be good if the angle between both the assets is at least 60 degrees.
Rest LGTM, also please use some good font.

@parth181195

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

@pAditya198 can you make different component for profile page icon cause it will not open pop up the model

@parth181195

This comment has been minimized.

Copy link
Collaborator

commented Aug 13, 2019

we also need to make some changes to input config
like we need to pass team member details in config, it only needs to have name and role plus profile links

@pAditya198

This comment has been minimized.

Copy link
Author

commented Aug 13, 2019

@parth181195 the profile page icon component that you are talking about is it similar to the speakerconfig or the speaker dialogue.

@pAditya198

This comment has been minimized.

Copy link
Author

commented Aug 13, 2019

Screenshot (73)

@rossoskull @aashutoshrathi @parth181195 please review
I've modified the Font and created a config for team as well as modified the team-card in the elements section for seperate data, and removed the pop-up in the team page.

@aashutoshrathi

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Can we atleast ensure this is Open Sans?

@pAditya198

This comment has been minimized.

Copy link
Author

commented Aug 13, 2019

@aashutoshrathi yes I've ensured it online

@aashutoshrathi
Copy link
Member

left a comment

  • Make sure the square asset have less than 60% perimeter outside.
  • Name and Post should have different font weights, fix that accordingly.
<div class="col-xs-12">
<app-homepage-title title='Team' color='#419BF9'></app-homepage-title>
</div>
<p>DevFest Gandhinagar is brought to you with 💓 love,

This comment has been minimized.

Copy link
@aashutoshrathi

aashutoshrathi Aug 13, 2019

Member

Can you replace this emoji with the simple ❤️ emoji

This comment has been minimized.

Copy link
@pAditya198

pAditya198 Aug 14, 2019

Author

@aashutoshrathi modified as per required please review again.

@pAditya198

This comment has been minimized.

Copy link
Author

commented Aug 14, 2019

Screenshot (75)

Name and Post font weight changed and also added the red heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.