Skip to content

Conversation

@johnzweng
Copy link
Contributor

Current problem:

  • The current implemetation of the Infura.io wallet tries to wait for a TransactionReceipt to get the txId of the created transaction.
  • This means it needs to wait until the transactions is mined into a block (which could take from seconds to hours).
  • The HTTP connection to infura does not stay open this long
  • Also, the txId is already available as soon as the signed transaction is created (its the hash), so no need to wait for a block just to get the txId

This Pull Request:

  • rewrites the sendCoins() method to use RawTransactionManager to manually create a transaction
  • it then immediately knows the txId and can return it immediately after broadcasting

@johnzweng
Copy link
Contributor Author

@johnzweng
Copy link
Contributor Author

Hi @pvyhnal-generalbytes !

I saw that you approved the PR yesterday. Thanks for that 🙂 !

I rebased it again on current origin/master (the only conflict was the comment in line 136-137 added in master branch). No changes in code, should now be mergable into master without conflict. 🙂

@filipocelka filipocelka merged commit 801f576 into GENERALBYTESCOM:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants