Event library interface #103

cjbacchus · 2020-05-04T17:02:12Z

for review meeting Thurs 7 May

…y yet.

…myPXSec to return nonzero values).

…to hack things. The physics is of course wrong.

…ct lepton universality in NC interactions, and fix a couple of bugs with the lepton flavour in those same interactions.

mroda88 · 2020-11-25T19:49:32Z

I tested the code. There is still come problem with the definition of daughter/mother relations

cjbacchus · 2020-11-25T19:51:53Z

Can you be more specific?

mroda88 · 2020-11-25T19:57:36Z

|GENIE GHEP Event Record [print level:   3]                                                                        |
|------------------------------------------------------------------------------------------------------------------|
| Idx |          Name | Ist |        PDG |   Mother  | Daughter  |      Px |      Py |      Pz |       E |      m  | 
|------------------------------------------------------------------------------------------------------------------|
|   0 |         nu_mu |   0 |         14 |  -1 |  -1 |   2 |   3 |   0.000 |   0.000 |   1.310 |   1.310 |   0.000 | 
|   1 |           C12 |   0 | 1000060120 |  -1 |  -1 |   3 |   4 |   0.000 |   0.000 |   0.000 |  11.175 |  11.175 | 
|   2 |       neutron |  11 |       2112 |  -1 |  -1 |   3 |   3 |   0.000 |   0.000 |   0.000 |   0.940 |   0.940 | 
|   3 |           mu+ |   1 |        -13 |   0 |  -1 |  -1 |  -1 |  -0.062 |   0.530 |   0.919 |   1.068 |   0.106 | 
|   4 |        proton |   1 |       2212 |   1 |  -1 |  -1 |  -1 |   0.167 |  -0.645 |   0.177 |   1.164 |   0.938 | 
|------------------------------------------------------------------------------------------------------------------|
|       Fin-Init:                                                |   0.105 |  -0.115 |  -0.214 | -10.253 |         | 
|------------------------------------------------------------------------------------------------------------------|

This is a snippet from one event. I don't know how it could be that the muon is coming out of a neutron. But I'm writing here to keep track of things, it's not necessary something you have to fix.

cjbacchus · 2020-11-25T19:59:50Z

Am I misreading that? Doesn't it say the mother index is zero, ie the neutrino?

mroda88 · 2020-11-25T20:02:34Z

yes, it says that and the daughter of the neutron is the muon as well.

mroda88

There a few major mistakes that makes the whole point of this library not even useful. I'll work on the fixes

mroda88 · 2020-11-26T13:16:48Z

config/EventGenerator.xml

+ -->
+  <param_set name="EventLibraryInterface">
+     <param type="string" name="VldContext"> </param>
+     <param type="int"    name="NModules">   1                                                    </param>


We need a dedicated inital state appender or the flux driver will never work properly

mroda88 · 2020-11-26T13:18:52Z

src/Framework/Interaction/ProcessInfo.h

@@ -80,6 +80,7 @@ class ProcessInfo : public TObject {
  bool IsWeakNC                  (void) const;
  bool IsWeakMix                 (void) const;
  bool IsDarkMatter              (void) const;
+  bool IsExternalGen             (void) const;


I'll try to find a way to not mix physics and framework.

mroda88 · 2020-11-26T13:19:45Z

src/Framework/Interaction/ScatteringType.h

@@ -51,7 +51,8 @@ typedef enum EScatteringType {
  kScIMDAnnihilation,
  kScDarkMatterElastic = 101,
  kScDarkMatterDeepInelastic,
-  kScDarkMatterElectron
+  kScDarkMatterElectron,
+  kScExternalGen = 900


probably it is better to define this negative as it's not physics

mroda88 · 2020-11-26T13:20:47Z

src/Tools/EvtLib/EventLibraryInterface.cxx

+  const int lastHad  = (rec->parts.size() == nLep) ? -1 : 1+rec->parts.size();
+
+  // Neutrino is a parent to the lepton(s)
+  event->AddParticle(init_state.ProbePdg(),


If we do this, we destroy the whole point of this exercise because we bypass the flux drivers that specifies the direction

mroda88 · 2020-11-26T13:21:32Z

src/Tools/EvtLib/EventLibraryInterface.cxx

+                     0, 0, 0, PDGLibrary::Instance()->Find(tgt_pdgc)->Mass(),
+                     0, 0, 0, 0);
+
+  // Include nuclear target in this position (2) by convention


This is not always the case, it should be dropped and it certainly it is not supposed to be taken from the Summary at this stage

mroda88 · 2020-11-26T16:55:39Z

src/Tools/EvtLib/EventLibraryInterface.cxx

+  if(up.Dot(z) == 0) up = TVector3(1, 0, 0);
+
+  const TVector3 x = up.Cross(z).Unit(); // Perpendicular to neutrino and up
+  const TVector3 y = x.Cross(z).Unit();  // Defines the third axis


this should be -y

…bRecord.

mroda88 · 2020-12-04T17:16:12Z

Merged manually

candreop and others added 30 commits March 9, 2020 16:26

first commit of VMC skeleton

ffb9e8b

Trivial build fixes

10e0a01

Direct port of RecordList classes from novasoft.

0e25754

Port in the body of the logic. Very unlikely to actually run correctl…

e5ae0dd

…y yet.

Refactor a little

cbbff3f

Add XML lines to be able to instantiate EventLibraryInterface

7872e3d

One more missing namespace

949f7f9

Configuration that gets a little further.

28ecd8e

Configuration options and better error handling.

23d1ba9

Generate random numbers in the correct way.

6ff6430

Use standard tools for neutrino name strings.

bc686ec

Another missing namespace waiting to bite us.

7e1a277

Get rid of the hardcoded list of nuclei names.

96c9596

An XML configuration that actually runs (if you also edit NNBarOscDum…

f216aa7

…myPXSec to return nonzero values).

Slightly more systematic directory naming.

d3c22ae

Make the lazy loading even lazier for faster startup.

708a232

Let's use a real xsec model so that it has splines and we don't have …

77ea624

…to hack things. The physics is of course wrong.

Satisfy picky XML parser

e3ada81

Use correct NC/CC information from the GHepRecord.

9dbf6d4

Sort out parent and child pointers.

608e0d6

Add our own trivial InteractionListGenerator for library generation.

7712c68

Add our own cross-section model too.

c6477a0

Now we control our own xsec model we can generate NC events as well.

59f96e1

Update to format with all record lists in one library file.

77dd1ea

Allow skipping missing trees.

faf780f

Automatically discover which nuclei are in the library file.

6cbbdd6

Factor out some pieces we'll need in a moment.

cf8726f

Load cross-sections from the library file.

e9e211f

Add nutau.

456bae3

Adjust to a reorganization of the library files to more clearly refle…

78757cd

…ct lepton universality in NC interactions, and fix a couple of bugs with the lepton flavour in those same interactions.

cjbacchus added 3 commits May 20, 2020 15:03

Put the whitespace back exactly as we found it.

942e442

Update comment.

6126c4a

Add --enable-event-library configure switch (defaulted to false).

a48d001

candreop added this to the 3.2.0 release milestone Jul 6, 2020

mroda88 added the framework Framework related issues or improvements label Oct 14, 2020

Redefinition of file path

7382d1e

mroda88 self-assigned this Nov 26, 2020

mroda88 requested changes Nov 26, 2020

View reviewed changes

mroda88 modified the milestones: 3.2.0 release, 3.2.2 Release Nov 26, 2020

mroda88 added 4 commits November 26, 2020 14:04

Fix issue with daughter/mother relations

33d1e6d

Create dedicated CommonParam for EX00_00a

1548067

Get Rid of hit nucleon

06d9af0

Proper record visitor chain

d035946

mroda88 reviewed Nov 26, 2020

View reviewed changes

mroda88 and others added 8 commits November 26, 2020 18:09

Add Proper rotations

c6ae1cb

temporary remove correction

db8e590

Hopefully fix the problem where neutrino energy was zero in the EvtLi…

2a19ebc

…bRecord.

Added library generation macro scheleton

0be81c0

start writing the factory

ff28882

Add an info about delta E

bebb7f0

Change interaction flag for external generator

20eae13

Merge branch 'master' into ExtNuGen

9411909

mroda88 closed this Dec 4, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Event library interface #103

Event library interface #103

cjbacchus commented May 4, 2020

mroda88 commented Nov 25, 2020

cjbacchus commented Nov 25, 2020

mroda88 commented Nov 25, 2020 •

edited

Loading

cjbacchus commented Nov 25, 2020

mroda88 commented Nov 25, 2020

mroda88 left a comment

mroda88 Nov 26, 2020

mroda88 Nov 26, 2020

mroda88 Nov 26, 2020

mroda88 Nov 26, 2020

mroda88 Nov 26, 2020

mroda88 Nov 26, 2020

mroda88 commented Dec 4, 2020

Event library interface #103

Event library interface #103

Conversation

cjbacchus commented May 4, 2020

mroda88 commented Nov 25, 2020

cjbacchus commented Nov 25, 2020

mroda88 commented Nov 25, 2020 • edited Loading

cjbacchus commented Nov 25, 2020

mroda88 commented Nov 25, 2020

mroda88 left a comment

Choose a reason for hiding this comment

mroda88 Nov 26, 2020

Choose a reason for hiding this comment

mroda88 Nov 26, 2020

Choose a reason for hiding this comment

mroda88 Nov 26, 2020

Choose a reason for hiding this comment

mroda88 Nov 26, 2020

Choose a reason for hiding this comment

mroda88 Nov 26, 2020

Choose a reason for hiding this comment

mroda88 Nov 26, 2020

Choose a reason for hiding this comment

mroda88 commented Dec 4, 2020

mroda88 commented Nov 25, 2020 •

edited

Loading