Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event library interface #103
Event library interface #103
Changes from 32 commits
ffb9e8b
10e0a01
0e25754
e5ae0dd
cbbff3f
7872e3d
949f7f9
28ecd8e
23d1ba9
6ff6430
bc686ec
7e1a277
96c9596
f216aa7
d3c22ae
708a232
77ea624
e3ada81
9dbf6d4
608e0d6
7712c68
c6477a0
59f96e1
77dd1ea
faf780f
6cbbdd6
cf8726f
e9e211f
456bae3
78757cd
1d3e6a3
fee6a25
e22790f
52b3290
ac43ad9
f2c7c18
afc92d4
f06d3d3
897ec3d
b76e67b
6fab4b4
8774a94
b1a65a9
b1c2e52
c8f6d7e
1c35b70
064b64a
af1f5ca
86d8b5a
773d92b
6d659d5
ef6d278
942e442
6126c4a
a48d001
7382d1e
33d1e6d
1548067
06d9af0
d035946
c6ae1cb
db8e590
2a19ebc
0be81c0
ff28882
bebb7f0
20eae13
9411909
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a dedicated inital state appender or the flux driver will never work properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not ok if we want to release it in v 3.2, otherwise it will be ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had no idea genie was compatible with such ancient standards. I take it the plan is to drop that requirement soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I set my built up to use C++98? There look to be a lot of places and I'm likely to miss one.
Alternately -- is it possible to have this component optional, and require a higher compiler version if it's enabled? I don't think any potential users are on anything like so old a standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here: not C++98