Small updates to Smirh-Monitz and BSKLN models #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the latest updates
Get last updates
fix sign in BSKLN model add some references add kine phase space transform. add energy threshold check
|
Approve because of no any suggestions or comments. |
igor144
added a commit
to igor144/Generator
that referenced
this pull request
Jul 2, 2020
Merge pull request GENIE-MC#107 from igor144/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There is a problem with the calculation of electron (anti)neutrino scattering on He3 and He4.
The Smith-Monitz model (like any other RFG model) is not applicable for such nuclei as He3 and He4, so we have never tested it for these cases. We consider a reaction of a neutrino with H1, H2 and H3 as a special case, so for these nuclei, everything works. The problem arises in the near-threshold region and is related to the kinematics, which depends on binding energies for He3 and He4.
We suggest an ad-hoc solution to the problem with calculation cross-section near to the threshold.
Set Q2_min = Q2_max instead of exit(1) and print the corresponding message. This will set the cross-section equal zero at near-threshold energies.
Change the binding energy for He3 and He4 and set them equal to 7.5 MeV and 27.4 MeV respectively according to most recent experimental data.
Speed up the integration for Smith-Monitz model.
Add kine phase space transformation for Smith-Monitz model.
Fix two bugs with signs for BSKLN model. These bugs do not affect anything, because they eliminate each other. It is done for the order.