Skip to content

Don't merge-branch for review!!! MK model with event generation used heuristic algorithm #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

idkakorin
Copy link
Contributor

No description provided.

@mroda88 mroda88 added this to the 3.2.0 release milestone Dec 18, 2020
@mroda88 mroda88 added framework Framework related issues or improvements modelling Issues with any aspect of physics modelling New Generator labels Dec 18, 2020
if (nucZ == 2)
{
if (nucA == 3)
return 7.5e-3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have references for these numbers that have been hardcoded?

@@ -81,7 +81,7 @@ const RSHelicityAmpl &
case (kD13_1520) :
{
double xt = 2* xi * fkr.T;
double xr = xi * fkr.R;
double xr = 3* xi * fkr.R;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be a bug fix?

Copy link
Member

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the changes in src/Physics/Resonance/XSection/RSHelicityAmplModelNCn.cxx and in the values of the weak constants, this pull request cannot go in as it is. I'll work on extracting the files that are ok in a dedicated pull request on the main repository.

@mroda88 mroda88 marked this pull request as draft January 22, 2021 16:08
@candreop candreop removed the generator label Apr 8, 2022
@mroda88 mroda88 closed this Jul 7, 2023
@mroda88 mroda88 deleted the MK_SPP_model_alt_max_search branch July 7, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework Framework related issues or improvements modelling Issues with any aspect of physics modelling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants