Don't merge-branch for review!!! MK model with event generation used heuristic algorithm #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
December 19, 2019 16:21
update baryon resonance parameters add Galster; MKCC and MKEM (needed for the model) form factors
mroda88
added
framework
mroda88
reviewed
Jan 18, 2021
| if (nucZ == 2) | ||
| { | ||
| if (nucA == 3) | ||
| return 7.5e-3; |
There was a problem hiding this comment.
can we have references for these numbers that have been hardcoded?
mroda88
reviewed
Jan 18, 2021
| @@ -81,7 +81,7 @@ const RSHelicityAmpl & | |||
| case (kD13_1520) : | |||
| { | |||
| double xt = 2* xi * fkr.T; | |||
| double xr = xi * fkr.R; | |||
| double xr = 3* xi * fkr.R; | |||
There was a problem hiding this comment.
Is this supposed to be a bug fix?
mroda88
reviewed
Jan 18, 2021
mroda88
requested changes
Jan 22, 2021
There was a problem hiding this comment.
Because of the changes in src/Physics/Resonance/XSection/RSHelicityAmplModelNCn.cxx and in the values of the weak constants, this pull request cannot go in as it is. I'll work on extracting the files that are ok in a dedicated pull request on the main repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.