-
Notifications
You must be signed in to change notification settings - Fork 101
Beam-produced, long-lived Heavy Neutral Lepton module for GENIE #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can only accept ROOT geometry files Will now write intersection method for top volume
Compiles. NHLDecayVolume replaces old `MINERvAGeom` with better abstraction
Can now (just about) detect when/if trajectory enters and exits geometry
This means don't kill the entire programme.
Turns out invoking `new NHLPrimaryVtxGenerator()` in the event loop was a bad idea...
Expand `SimpleNHL` to keep these and talk to app
Turn back and use one `TGeoManager::FindNextBoundaryAndStep()` call, optimisation is still massive!
No longer is it necessary to perform `genie_pdg_table.txt` surgery to get a GST. Yay.
Copied relevant code to private utility function
Added in options: `RerollPoints` if you want those points with accCorr = 0.0 to be given another chance in the bounding box. `CollectionRadius` specifies size of box around det centre to estimate flux with (if `DoOldFluxCalculation == false`)
Added custom `genie::hnl::FluxContainer` class to handle flux packaging. This was formerly done by `genie::flux::GNuMIFluxPassThroughInfo`, but it is better to formally decouple these interfaces. NB: this is stricto senso only validated for unrotated detectors with no offset. Debug flags are still on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work addressing previous comments. Seems to me like this is at a stage where it can be committed to the master.
@mroda88 what are we doing with this development? I think it looks good now and there were several rounds of comments and improvements. If we keep on looking we may well find some minor points to address, but I don't think we would find any substantial new issue. This adds important new physics functionality, is well validated and well publicised (PRD paper, DUNE CM presentations) and I think it is time to merge with the master. |
Sounds great! So I think on Friday we wanted to merge the dune spectral function approach. After that is merged, if there are no conflicts we can merge this too! I'll coordinate with John for the details. Is it ok? The alternative is that we can discuss it briefly on the next core meeting. But this is BSM physics so I don't see reason to delay that much. I'll check with Steven Gardiner too. |
Sounds good. Yeah, probably no reason to delay till the core mtg. It is entirely orthogonal to everything else, including the other BSM modes. |
An implementation of long-lived HNL produced in a neutrino beam and propagating to a detector.
Introduces 3 new Apps
gevgen_hnl, gevgen_pghnl, gevald_hnl
and thePhysics/BeamHNL
package, as well as the config filesCommonHNL.xml, BeamHNLGenerator.xml
.gevgen_hnl
is the canonical event generation App using flattened dk2nu flux input and a ROOT geometry detector description.gevgen_pghnl
is an HNL particle gungevald_hnl
is a suite of validation tools for HNLMore information in the following file:
Beam-produced Heavy Neutral Leptons in GENIE v3.pdf