Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New options for GMCJDriver #75

Merged
merged 4 commits into from Apr 28, 2020
Merged

Conversation

pochoarus
Copy link
Contributor

@pochoarus pochoarus commented Nov 20, 2019

New options:
-force the interaction.
-use logarithmic binning in pmax.
-change the safety factor.

Copy link
Member

@candreop candreop left a comment

This set of changes seems OK to me. Any comments @nusense ? Otherwise will merge sometime later this week.

Copy link
Member

@nusense nusense left a comment

let me try this again

src/Framework/EventGen/GMCJDriver.cxx Outdated Show resolved Hide resolved
src/Framework/EventGen/GMCJDriver.cxx Outdated Show resolved Hide resolved
src/Framework/EventGen/GMCJDriver.cxx Outdated Show resolved Hide resolved
@pochoarus
Copy link
Contributor Author

pochoarus commented Apr 22, 2020

i've modified the code in order to address robert's suggestion.

Copy link
Member

@nusense nusense left a comment

Github's diff engine makes this a bit confusing to review (it's not very smart about small additions, and it makes it look like big blocks of code are being deleted and then added). But I think this change addresses the issues I had concerns about.

@candreop candreop merged commit bf24843 into GENIE-MC:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants