-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New options for GMCJDriver #75
Conversation
…mic binning in pmax and to change the safety factor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This set of changes seems OK to me. Any comments @nusense ? Otherwise will merge sometime later this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me try this again
i've modified the code in order to address robert's suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github's diff engine makes this a bit confusing to review (it's not very smart about small additions, and it makes it look like big blocks of code are being deleted and then added). But I think this change addresses the issues I had concerns about.
New options:
-force the interaction.
-use logarithmic binning in pmax.
-change the safety factor.