automatically select flux surface radii for ROOT geometries #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates gevgen_atmo to automatically select the longitudinal and transverse radii for the flux surface when using a ROOT geometry and if the two radii are not specified on the command line. If this is the case, both are set to the diagonal of the bounding box of the geometry.
|
This seems fine to me. It is a clever trick. Any comment @nusense ? Otherwise will merge the pull request |
|
Sorry, I overlooked the request for comment here. No this look good. I love it when best guesses get handled automagically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates gevgen_atmo to automatically select the longitudinal and
transverse radii for the flux surface when using a ROOT geometry and if the two
radii are not specified on the command line. If this is the case, both are set
to the diagonal of the bounding box of the geometry.
I believe the diagonals of the bounding box should be large enough to correctly sample the neutrino interaction vertices assuming that the origin of the ROOT geometry is within the bounding box.
I have not extensively tested this. So far I have done some basic testing with a similar commit applied to version 2.12.8 and have just made sure that the pull request compiles on master so it should probably get tested more before being merged.