Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically select flux surface radii for ROOT geometries #93

Merged
merged 1 commit into from Mar 6, 2020

Conversation

tlatorre-uchicago
Copy link
Contributor

@tlatorre-uchicago tlatorre-uchicago commented Feb 19, 2020

This commit updates gevgen_atmo to automatically select the longitudinal and
transverse radii for the flux surface when using a ROOT geometry and if the two
radii are not specified on the command line. If this is the case, both are set
to the diagonal of the bounding box of the geometry.

I believe the diagonals of the bounding box should be large enough to correctly sample the neutrino interaction vertices assuming that the origin of the ROOT geometry is within the bounding box.

I have not extensively tested this. So far I have done some basic testing with a similar commit applied to version 2.12.8 and have just made sure that the pull request compiles on master so it should probably get tested more before being merged.

This commit updates gevgen_atmo to automatically select the longitudinal and
transverse radii for the flux surface when using a ROOT geometry and if the two
radii are not specified on the command line. If this is the case, both are set
to the diagonal of the bounding box of the geometry.
@candreop
Copy link
Member

candreop commented Feb 26, 2020

This seems fine to me. It is a clever trick. Any comment @nusense ? Otherwise will merge the pull request

@nusense
Copy link
Member

nusense commented Mar 6, 2020

Sorry, I overlooked the request for comment here. No this look good. I love it when best guesses get handled automagically.

@nusense nusense merged commit 54be7a8 into GENIE-MC:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants