-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entry type:layer to replace mvt_clone #1386
Draft
dbauszus-glx
wants to merge
11
commits into
GEOLYTIX:main
Choose a base branch
from
dbauszus-glx:layer-entry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbauszus-glx
added
Bug
A genuine bug. There must be some form of error exception to work with.
Feature
New feature requests or changes to the behaviour or look of existing application features.
labels
Jul 18, 2024
dbauszus-glx
requested review from
cityremade,
AlexanderGeere,
RobAndrewHurst and
simon-leech
July 18, 2024 17:57
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mvt_clone type entry had several bugs and applied an unnecessary complex logic.
The mvt_clone module has been removed and the mvt_clone entry method has been deprecated. The mvt_clone method will warn and return the new layer entry method.
A
layer.featureSet
filter has been to the featureStyle method. Feature not included in the featureSet will not be styled.The
layer/format/mvt
module documentation has been revised. The clone logic has been removed.The
type:layer
entry method assigns a Key property which is the orignal layer key required to get a location.The
highlight
interactiongetFeature
method has been updated to recognise the layer.Key property.related fixes:
Removed
layer/featureStyle
module function params.Added missing
@requires
to/ui/locations/entries
module.Fixed
/ui/locations/entries/numeric
declaration.Fixed
/layer/changeEnd
declaration.Removed deprecated ui/locations/entries/default module.