Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entry type:layer to replace mvt_clone #1386

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dbauszus-glx
Copy link
Member

@dbauszus-glx dbauszus-glx commented Jul 18, 2024

The mvt_clone type entry had several bugs and applied an unnecessary complex logic.

The mvt_clone module has been removed and the mvt_clone entry method has been deprecated. The mvt_clone method will warn and return the new layer entry method.

A layer.featureSet filter has been to the featureStyle method. Feature not included in the featureSet will not be styled.

The layer/format/mvt module documentation has been revised. The clone logic has been removed.

The type:layer entry method assigns a Key property which is the orignal layer key required to get a location.

The highlight interaction getFeature method has been updated to recognise the layer.Key property.

related fixes:

Removed layer/featureStyle module function params.

Added missing @requires to /ui/locations/entries module.

Fixed /ui/locations/entries/numeric declaration.

Fixed /layer/changeEnd declaration.

Removed deprecated ui/locations/entries/default module.


@dbauszus-glx dbauszus-glx self-assigned this Jul 18, 2024
@dbauszus-glx dbauszus-glx added Bug A genuine bug. There must be some form of error exception to work with. Feature New feature requests or changes to the behaviour or look of existing application features. labels Jul 18, 2024
@dbauszus-glx dbauszus-glx linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Sep 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A genuine bug. There must be some form of error exception to work with. Feature New feature requests or changes to the behaviour or look of existing application features. v4.11.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vector_layer and mvt_clone
2 participants