Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pangea4 host configs #3081

Merged
merged 13 commits into from
Jun 13, 2024
Merged

Add Pangea4 host configs #3081

merged 13 commits into from
Jun 13, 2024

Conversation

Bubusch
Copy link
Contributor

@Bubusch Bubusch commented Apr 16, 2024

Adds the Pangea 4 host config files :

host-config Description Compiler MPI BLAS-LAPACK
pangea4-base.cmake base configuration for Pangea4 (CPU cluster) using Hypre, no openMP X X X
pangea4-gcc12.1-hpcxompi2.17.1-onemkl2023.2.0 default gcc build cray wrappers for gnu (cc, CC, ftn) HPC-X OpenMPI oneAPI MKL
pangea4-gcc12.1-openmpi4.1.6-onemkl2023.2.0 alternative gcc build cray wrappers for gnu (cc, CC, ftn) OpenMPI oneAPI MKL
pangea4-gcc12.1-openmpi4.1.6-openblas0.3.23 alternative gcc build cray wrappers for gnu (cc, CC, ftn) OpenMPI OpenBLAS
pangea4-gcc12.1-hpcxompi2.17.1-openblas0.3.23 alternative gcc build cray wrappers for gnu (cc, CC, ftn) HPC-X OpenMPI OpenBLAS

Linked to TPLs' PR #262.

@Bubusch Bubusch self-assigned this Apr 16, 2024
@Bubusch Bubusch added flag: no rebaseline Does not require rebaseline type: feature New feature or request flag: requires updated TPL(s) Needs a specific TPL PR labels Apr 16, 2024
host-configs/TOTAL/pangea4-base.cmake Show resolved Hide resolved
host-configs/TOTAL/pangea4-base.cmake Outdated Show resolved Hide resolved
Comment on lines 54 to 55
set( COMMON_FLAGS "-O3 -march=native -mtune=native" )
set( RELEASE_FLAGS "-DNDEBUG" )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need those explicit flags? I thought that -O3 was already enabled.

Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update. Now, I can successfully compile TPLs and GEOS with hpcx-ompi, which is being used to run SEAM cases on P4. However, encountered some troubles on compilation with openmpi.

@MelReyCG MelReyCG self-requested a review April 19, 2024 07:42
Copy link
Contributor

@MelReyCG MelReyCG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

Copy link
Contributor

@jhuang2601 jhuang2601 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I've successfully compiled GEOS with the default one and completed multiple SEAM cases on P4.

# SCIENTIFIC LIBRARIES
#######################################

set( ENABLE_FESAPI ON CACHE BOOL "" FORCE )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove ENABLE_FESAPI #2969

@Bubusch Bubusch marked this pull request as ready for review May 31, 2024 11:52
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.78%. Comparing base (4de1337) to head (62e979a).
Report is 104 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3081      +/-   ##
===========================================
+ Coverage    53.74%   53.78%   +0.04%     
===========================================
  Files         1016     1016              
  Lines        85756    85826      +70     
===========================================
+ Hits         46092    46165      +73     
+ Misses       39664    39661       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bubusch Bubusch added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jun 3, 2024
@Bubusch
Copy link
Contributor Author

Bubusch commented Jun 4, 2024

will run integrated tests just before merge (as no rebase line is required)

@CusiniM CusiniM added the ci: run integrated tests Allows to run the integrated tests in GEOS CI label Jun 13, 2024
@CusiniM CusiniM merged commit 236ba64 into develop Jun 13, 2024
27 checks passed
@CusiniM CusiniM deleted the feature/bubusch/pangea4 branch June 13, 2024 21:19
@Bubusch Bubusch mentioned this pull request Jun 14, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: requires updated TPL(s) Needs a specific TPL PR type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants