-
Notifications
You must be signed in to change notification settings - Fork 15
Spack 1.0.2 #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spack 1.0.2 #324
Conversation
|
@matteofrigo5 we're having issues with the Sherlock jobs and it's not very clear what's going on. Given it's using centos 7, which already reached EOL, how about we upgrade those images to let's say Alma/Rocky 9? Would that work for Sherlock? |
…ation failure to work through
Co-authored-by: Brian Han <han12@llnl.gov>
Improve uberenv build scripts
|
@CusiniM @jhuang2601 @Bubusch @klevzoff @MichaelSekachev @bd713 @rrsettgast @victorapm Please be aware of likely breaking changes in this PR moving to Spack 1.0.2, related to the deprecation of |
|
Thanks a lot for this, @bmhan12! I noticed Sergey's PR to upstream the scotch changes have been merged: spack/spack-packages#1692 Perhaps, we can remove our internal scotch package. @klevzoff please let us know |
Yes, if we are able to move |
Thanks for working on the spack upgrade. |
Either way is fine with me! I want to note that there are some unit test failures with some of the Docker images, looking into fixes/workarounds. |
|
@bmhan12 just pushed the |
|
@bmhan12 I've just updated |
Thanks @bd713 for updating spack config for Pine. And GEOS can also be compiled and pass all unit tests there: |
|
successful builds on LC: dane-toss_4_x86_64_ib-gcc@13.3.1.cmake matrix-toss_4_x86_64_ib-gcc@12.1.1-cuda@12.6.0.cmake tuolumne-toss_4_x86_64_ib_cray-cce@20.0.0-rocm@6.4.2.cmake failed builds on LC: |
Thanks @rrsettgast ! I'll take a look at the two failures. |
Related PR: GEOS-DEV/GEOS#3848
This PR:
uberenvsubmodule--no-permissionsflag to build scripts so we can run them without the admin account--cleanflag to clean previous build if existenttoss_4_x86_64_ibandtoss_4_x86_64_ib_cray. Flex will be built via spack (relevant discussion on flex/bison: Update scotch to 7.0.8 and add/fix determinism flags #314 (comment))hdf5llvm-amdgpurecipe to get a build with said compiler working.Note:
spack.yamlfile using the pre-1.0compilerssyntax. Spack will try to take the pre-1.0spack.yamland auto-convert it to a 1.0 syntax, but this does not guarantee it will work. Importantly, Spack 1.0's auto-conversion will not use the newtoolchainssyntax, which in Spack 1.0 is how we ensure specific compilers are used like in the pre-1.0compilerssyntax: https://spack.readthedocs.io/en/latest/toolchains_yaml.htmltoolchainschanges to the Github Actions and LC systemspack.yamlenvironment files. Caretakers of other systems will need to update theirspack.yamlenvironment files to usetoolchainsand test accordingly.compilersto 1.0toolchains:toss_4_x86_64_ibswitches external blas/lapack fromintel-oneapi-mkltoopenblasdue to open Spack issue: https://github.com/spack/spack/issues/49994matrixthere are unit test failures related to OpenMP inhypre. A fix is in-progress, will require a hypre update later.