Skip to content

Conversation

@bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Oct 2, 2025

Related PR: GEOS-DEV/GEOS#3848

This PR:

  • Moves spack version to 1.0.2
  • Updates uberenv submodule
  • Add --no-permissions flag to build scripts so we can run them without the admin account
  • Add --clean flag to clean previous build if existent
  • Fix compiler order in the machine specs according to spack v1
  • Bump up build_jobs for matrix and tuo
  • Fix matrix arch
  • Fix ATS flags for Dane and Matrix
  • Add bison, ninja, and gcc-runtime to toss_4_x86_64_ib and toss_4_x86_64_ib_cray. Flex will be built via spack (relevant discussion on flex/bison: Update scotch to 7.0.8 and add/fix determinism flags #314 (comment))
  • Use upstream recipe for hdf5
  • Adds workaround to llvm-amdgpu recipe to get a build with said compiler working.

Note:

@victorapm
Copy link
Contributor

victorapm commented Oct 3, 2025

@matteofrigo5 we're having issues with the Sherlock jobs and it's not very clear what's going on.

Given it's using centos 7, which already reached EOL, how about we upgrade those images to let's say Alma/Rocky 9? Would that work for Sherlock?

This was referenced Oct 3, 2025
@bmhan12 bmhan12 changed the title [WIP] Spack 1.0.2 Spack 1.0.2 Oct 10, 2025
@bmhan12 bmhan12 marked this pull request as ready for review October 10, 2025 15:01
@bmhan12
Copy link
Contributor Author

bmhan12 commented Oct 10, 2025

@CusiniM @jhuang2601 @Bubusch @klevzoff @MichaelSekachev @bd713 @rrsettgast @victorapm
Tagged based on repo activity managing spack.yaml environment files.

Please be aware of likely breaking changes in this PR moving to Spack 1.0.2, related to the deprecation of compilers in favor of toolchains. See PR description for more details.

@victorapm
Copy link
Contributor

Thanks a lot for this, @bmhan12!

I noticed Sergey's PR to upstream the scotch changes have been merged: spack/spack-packages#1692

Perhaps, we can remove our internal scotch package. @klevzoff please let us know

@klevzoff
Copy link
Contributor

Thanks a lot for this, @bmhan12!

I noticed Sergey's PR to upstream the scotch changes have been merged: spack/spack-packages#1692

Perhaps, we can remove our internal scotch package. @klevzoff please let us know

Yes, if we are able to move spack_packages_commit to anything past spack/spack-packages@6690c04 we can drop our local scotch package. We can also do this later to avoid adding more work/testing to this PR - looks like now it should be easy to update spack-packages without updating Spack itself, given that they maintain a stable package API.

@Bubusch
Copy link
Contributor

Bubusch commented Oct 17, 2025

@CusiniM @jhuang2601 @Bubusch @klevzoff @MichaelSekachev @bd713 @rrsettgast @victorapm Tagged based on repo activity managing spack.yaml environment files.

Please be aware of likely breaking changes in this PR moving to Spack 1.0.2, related to the deprecation of compilers in favor of toolchains. See PR description for more details.

Thanks for working on the spack upgrade.
I have made a spack v1.0.2 compatible version of Pangea-4 spack configuration, shall I push it here or in another PR ?

@bmhan12
Copy link
Contributor Author

bmhan12 commented Oct 17, 2025

Thanks for working on the spack upgrade. I have made a spack v1.0.2 compatible version of Pangea-4 spack configuration, shall I push it here or in another PR ?

Either way is fine with me!

I want to note that there are some unit test failures with some of the Docker images, looking into fixes/workarounds.

@Bubusch
Copy link
Contributor

Bubusch commented Oct 20, 2025

@bmhan12 just pushed the pangea-4 config.
Also, it's likely that I’ll remove the pangea-3 config and related builds soon (pending final decommissioning approval from project leads). So if they cause any issues, feel free to just deactivate them.

@bd713
Copy link

bd713 commented Oct 21, 2025

@bmhan12 I've just updated Pine config file.
@dkachuma @jhuang2601 Could you confirm it works for you as well? Please note that this new version relies on OpenBlas.

@jhuang2601
Copy link
Contributor

@bmhan12 I've just updated Pine config file. @dkachuma @jhuang2601 Could you confirm it works for you as well? Please note that this new version relies on OpenBlas.

Thanks @bd713 for updating spack config for Pine.
I can confirm that TPLs was successfully compiled:

[+] /shared/data1/Users/j0551570/Compilation/WIP_Spack_Pine/build/gcc-11.4.1/scotch-7.0.8-jwp7nzdmrxuapttlzttus5sapcrwlkl3
==> Installing scotch-7.0.8-jwp7nzdmrxuapttlzttus5sapcrwlkl3 [56/57]
==> No binary for geosx-develop-xom5kvlh7ebqdrywrjp6q6ihdxtrjhfa found: installing from source
==> No patches needed for geosx
==> geosx: Executing phase: 'geos_hostconfig'
==> geosx: Executing phase: 'lvarray_hostconfig'
==> geosx: Successfully installed geosx-develop-xom5kvlh7ebqdrywrjp6q6ihdxtrjhfa
  Stage: 0.00s.  Geos_hostconfig: 0.01s.  Lvarray_hostconfig: 0.00s.  Post-install: 0.08s.  Total: 0.24s
[+] /shared/data1/Users/j0551570/Compilation/WIP_Spack_Pine/build/gcc-11.4.1/geosx-develop-xom5kvlh7ebqdrywrjp6q6ihdxtrjhfa
==> Installing geosx-develop-xom5kvlh7ebqdrywrjp6q6ihdxtrjhfa [57/57]

And GEOS can also be compiled and pass all unit tests there:

247/247 Test #247: testWavePropagationAdjoint1 .............................   Passed    5.52 sec

100% tests passed, 0 tests failed out of 247

Total Test time (real) = 132.58 sec

@rrsettgast
Copy link
Member

successful builds on LC:

dane-toss_4_x86_64_ib-gcc@13.3.1.cmake
dane-toss_4_x86_64_ib-llvm@14.0.6.cmake
dane-toss_4_x86_64_ib-llvm@19.1.3.cmake

matrix-toss_4_x86_64_ib-gcc@12.1.1-cuda@12.6.0.cmake
matrix-toss_4_x86_64_ib-gcc@13.3.1-cuda@12.9.1.cmake
matrix-toss_4_x86_64_ib-llvm@19.1.3-cuda@12.9.1.cmake

tuolumne-toss_4_x86_64_ib_cray-cce@20.0.0-rocm@6.4.2.cmake
tuolumne-toss_4_x86_64_ib_cray-llvm-amdgpu@6.4.2-rocm@6.4.2.cmake

failed builds on LC:
dane-gcc-12.log
matrix-clang-14-cuda-12.6.log

@bmhan12
Copy link
Contributor Author

bmhan12 commented Oct 30, 2025

failed builds on LC:

Thanks @rrsettgast ! I'll take a look at the two failures.

@jhuang2601 jhuang2601 merged commit 89afa74 into master Oct 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants