Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public init for Feature #154

Merged
merged 1 commit into from Apr 25, 2019

Conversation

sauvikated
Copy link
Contributor

It will be really nice to be able to create an instance of Feature, adding values to it and substantially create a collection of them as Features.

Scenario:

Suppose we have [String] of encoded polylines generated using - (NSString *) encodedPath on an instance of GMSPath while recoding a transportation movement by a vehicle . Documentation.

So we can

  1. Iterate over the [String],
  2. Decode each single encoded string
  3. Create an instance of LineString from it
  4. Add the LineString instance to the geometries of Feature
  5. Add additional values for properties and id
  6. Create a Features inserting every single Feature

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #154 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #154   +/-   ##
========================================
  Coverage    71.82%   71.82%           
========================================
  Files           10       10           
  Lines          820      820           
========================================
  Hits           589      589           
  Misses         231      231
Impacted Files Coverage Δ
GEOSwift/Feature.swift 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ba44db...77560d0. Read the comment docs.

@macdrevx
Copy link
Member

@sauvikated, thanks for the PR. Can you update it to be based off of develop instead of master?

@sauvikated sauvikated changed the base branch from master to develop April 24, 2019 12:09
@sauvikated
Copy link
Contributor Author

@macdrevx Done.

@macdrevx
Copy link
Member

I rebased onto develop to get rid of those merge commits.

@macdrevx macdrevx merged commit 55cd3d7 into GEOSwift:develop Apr 25, 2019
@macdrevx
Copy link
Member

This will go out with the next release along with #153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants