From f356430a5d870ed78e969603743bd4bf3ebe0cf7 Mon Sep 17 00:00:00 2001 From: Kasper Keunen Date: Wed, 29 Apr 2026 13:53:45 -0500 Subject: [PATCH] ci(cd_pr): skip argocd_diff for PRs targeting development MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The testing ArgoCD instance at https://argocd.euc1.t.get-protocol.dev is currently unreachable (HTTP 503). The diff job calls /api/v1/applications on that host, gets HTML back instead of JSON, and fails. This breaks every PR opened against development across every repo using this reusable workflow — message-service, entrails, and others. Skipping the job for development base unblocks those PRs without losing visibility on master/production diffs (production ArgoCD is healthy). When the testing cluster is restored, revert the if condition. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/cd_pr.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/cd_pr.yml b/.github/workflows/cd_pr.yml index fc18d1e..726c180 100755 --- a/.github/workflows/cd_pr.yml +++ b/.github/workflows/cd_pr.yml @@ -53,7 +53,15 @@ jobs: argocd_diff: runs-on: [self-hosted, ubuntu20.04-self] - if: github.base_ref == 'development' || github.base_ref == 'master' || github.base_ref == 'production' + # NOTE: 'development' base is intentionally excluded. + # The testing ArgoCD instance at https://argocd.euc1.t.get-protocol.dev + # is currently unreachable (HTTP 503) — there is no live server for the + # diff to query, so the job would fail on every PR targeting development. + # Production ArgoCD (https://argocd.euc1.get-protocol.cloud) is healthy + # and the diff still gates PRs targeting master and production. + # When the testing cluster is restored, add `github.base_ref == 'development' ||` + # back to the condition below. + if: github.base_ref == 'master' || github.base_ref == 'production' steps: - id: argocd shell: bash