[GFA1] improve definition of C lines (after #58) #65

Merged
merged 6 commits into from Jul 6, 2017

Conversation

Projects
None yet
2 participants
Contributor

ggonnella commented Jul 5, 2017

This branch reconstructs the commits of the merge request #58 and applies them to the current master branch.

ggonnella changed the title from Fix gfa1 c definition to [GFA1] improve definition of C lines (after #58) Jul 5, 2017

Contributor

ggonnella commented Jul 5, 2017

This PR closes issue #57

sjackman self-assigned this Jul 5, 2017

Collaborator

sjackman commented Jul 5, 2017

This PR achieved quorum in PR #57.

GFA1.md
@@ -132,19 +132,31 @@ The Overlap field is optional and can be `*`, meaning that the CIGAR string is n
# `C` Containment line
-A containment line represents an overlap between two segments where one is contained in the other.
+A containment line represents an overlap between two segments where one (the `Container` segment)
+is contained in the other (the `Contained` segment). The `Pos` field stores the leftmost
@sjackman

sjackman Jul 5, 2017

Collaborator

I believe Container and Contained should be swapped in the following sentence.

A containment line represents an overlap between two segments where one (the Container segment) is contained in the other (the Contained segment).

@ggonnella

ggonnella Jul 6, 2017

Contributor

Well spotted

@sjackman sjackman merged commit 9f86b36 into GFA-spec:master Jul 6, 2017

Collaborator

sjackman commented Jul 6, 2017

Merged. Thanks for your contribution to the GFA 1 spec, Giorgio!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment