Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translation update #290

Merged
merged 7 commits into from Jul 24, 2019

Conversation

@Yvan-Masson
Copy link

commented Jul 21, 2019

Proposal of French translation update. Note that:

  • I did not translated some strings because I could not find their context
  • I could not find a proper translation for "Hole-filled seamless SRTM data", so I removed the "Hole-filled seamless" part of the string

TimMcCauley and others added some commits Dec 18, 2018

Fix missing fuel endpoint
change fuel option initialization
French translation update
Proposal of French translation update. Note that:
- I did not translated some strings because I could not find their context
- I could not find a proper translation for "Hole-filled seamless SRTM data", so I removed the "Hole-filled seamless" part of the string

@sfendrich sfendrich self-requested a review Jul 22, 2019

@sfendrich sfendrich self-assigned this Jul 22, 2019

@sfendrich sfendrich changed the base branch from master to development Jul 22, 2019

@sfendrich

This comment has been minimized.

Copy link

commented Jul 22, 2019

Thank you very much for this great contribution!

* I did not translated some strings because I could not find their context

Would you mind to check my (upcoming) suggestions and comments to these open items, so we can complete the translation?

Show resolved Hide resolved app/languages/fr-FR.json Outdated
Show resolved Hide resolved app/languages/fr-FR.json Outdated
Show resolved Hide resolved app/languages/fr-FR.json Outdated
Show resolved Hide resolved app/languages/fr-FR.json Outdated
Show resolved Hide resolved app/languages/fr-FR.json Outdated
Show resolved Hide resolved app/languages/fr-FR.json Outdated
Show resolved Hide resolved app/languages/fr-FR.json Outdated
@sfendrich

This comment has been minimized.

Copy link

commented Jul 23, 2019

@Yvan-Masson Thanks again for your work. Could you update your PR according to our discussions? Afterwards we'll be ready to merge.

@sfendrich sfendrich merged commit 0522c9d into GIScience:development Jul 24, 2019

1 check passed

security/snyk - package.json (HeiGit) No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.