Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheelchair enhancements #197

Merged
merged 26 commits into from Jun 16, 2018
Merged

Wheelchair enhancements #197

merged 26 commits into from Jun 16, 2018

Conversation

rabidllama
Copy link
Contributor

Pull Request Checklist

  • 1. I have merged the latest version of the development branch into my feature branch and all conflicts have been resolved
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the [Unreleased] heading
  • 3. I have documented my code using JDocs tags
  • 4. I have removed unecessary commented out code, imports and System.out.println statements
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass
  • 6. I have created API tests for any new functionality exposed to the API
  • 7. If changes/additions are made to the app.config file, I have added these to the app.config.sample file along with a short description of what it is for, and documented this in the Pull Request (below)
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue)
  • 10. For new features involving building of graphs, I have tested on a larger dataset (at least Germany) and the graphs build without problems (i.e. no out-of-memory errors)
  • 11. I have written in the Pull Request information about the changes made including their intended usage and why the change was needed.

Fixes #162 .

Information about the changes

  • Key functionality added: The Wheelchair profile has been updated to be more efficient and addres restrictions better.
  • Reason for change:

Required changes to app.config (if applicable)

  • The wheelchair profile in the app.config has been updated with a parameter that tells the system whether kerb heights should only be attached to crossings (better) or on any way that the node is part of.

…ewalk, and when . is used rather than : in tag keys
…s this is done anyway during the edge processing
…stone in wheelchair profile and surface material extension, and replaced the Salt surface id with PavingStone
…ser to the points when using wheelchair profile, and updated tests regarding the changing of surface materials
@rabidllama rabidllama added this to the 4.6 milestone Jun 15, 2018
@rabidllama rabidllama added this to Developed - waiting for merge in ors v4.6 Jun 15, 2018
Copy link
Contributor

@TimMcCauley TimMcCauley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@TimMcCauley TimMcCauley merged commit f5a89ee into development Jun 16, 2018
@rabidllama rabidllama moved this from Developed - waiting for merge to Merged - waiting for release in ors v4.6 Jun 26, 2018
@rabidllama rabidllama removed this from Merged - waiting for release in ors v4.6 Aug 2, 2018
@rabidllama rabidllama deleted the wheelchair_enhancements branch February 25, 2019 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants