Matrix flexible mode location count restriction #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabidllama
requested changes
Feb 6, 2018
There was a problem hiding this comment.
Just needs the maximum_locations_flexible property adding to the app.config.sample file along with a comment about what it is for so that people creating future instances know that it is available.
Also, please add a little about it to the CHANGELOG.md under the [Unreleased] heading.
| @@ -39,6 +40,9 @@ | |||
| value = AppConfig.Global().getServiceParameter("matrix", "maximum_locations"); | |||
| if (value != null) | |||
| maximumLocations = Math.max(1, Integer.parseInt(value)); | |||
| value = AppConfig.Global().getServiceParameter("matrix", "maximum_locations_flexible"); | |||
There was a problem hiding this comment.
I have added the parameter to the staging app.config, but it would be good to have it added to the app.config.sample file within the repository so that it is there ready for new instances
rabidllama
approved these changes
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Restricts the matrix requests locations to a diffferent (lower) value if not using profile driving-car or hgv (i.e. if there is no CH profile for the requested profile).
😄
The additional parameter still needs to be added to the app.config in
ors -> services -> matrixafter the entry
maximum_locationsand is calledmaximum_locations_flexible: 25@TimMcCauley pleaseFallback to value of 25 if the parameter is not set is hardcoded.
Resolves #94