Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove distance and duration text from route popup #366

Conversation

TheGreatRefrigerator
Copy link
Collaborator

as the value and unit is enough to infer what it describes, the localized strings for distance and duration are removed

@koebi
Copy link
Collaborator

koebi commented May 30, 2023

For visible distinction between distance and duration, I'd suggest placing the duration on top and in bold face, and distance below.

@TheGreatRefrigerator TheGreatRefrigerator force-pushed the feat/345-remove-distance-and-duration-text-in-route-labels branch from a2af98d to 5c0702a Compare May 30, 2023 10:40
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelsJP MichaelsJP force-pushed the feat/345-remove-distance-and-duration-text-in-route-labels branch from 5c0702a to 209cdfa Compare May 30, 2023 11:25
@MichaelsJP MichaelsJP enabled auto-merge May 30, 2023 11:26
@MichaelsJP MichaelsJP disabled auto-merge May 30, 2023 11:28
as the value and unit is enough to infer what it describes,
the localized strings for distance and duration are removed

also
- move duration above distance
- make duration bold
@TheGreatRefrigerator TheGreatRefrigerator force-pushed the feat/345-remove-distance-and-duration-text-in-route-labels branch from 209cdfa to 6f5e0b8 Compare May 30, 2023 15:11
@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheGreatRefrigerator TheGreatRefrigerator merged commit 6e4d420 into main May 30, 2023
@TheGreatRefrigerator TheGreatRefrigerator deleted the feat/345-remove-distance-and-duration-text-in-route-labels branch May 30, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'distance' and 'duration' text in route labels
2 participants