Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document when a model is deleted and make it able to revert #1257

Open
childers opened this issue Sep 14, 2016 · 8 comments

Comments

Projects
None yet
3 participants
@childers
Copy link
Collaborator

commented Sep 14, 2016

Is there any log for when a model is deleted? I'm not thinking about undoing a delete option, but rather taking note when models are deleted, who created the model and who deleted the model.

@nathandunn nathandunn added this to the 2.0.5 milestone Sep 14, 2016

nathandunn added a commit to nathandunn/Apollo that referenced this issue Sep 14, 2016

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2016

It should be populated in the feature_event table, but I see that it is not. When you delete an exon you can see that the DELETE_EXON operation is recorded. See PR #1259.

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Sep 14, 2016

You could also check for FeatureEvents that are missing in the Feature table.

@childers Can you clarify the use-case a bit more?

@childers

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 15, 2016

Someone may have been deleting models, and I'd really like to know if I can:

  1. Track models that annotators have used, especially if the creator and deletor are different users
    optionally:
  2. have some way to roll back the removal if the original model should not have been deleted

@nathandunn nathandunn self-assigned this Sep 15, 2016

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2016

  • handle delete_feature
  • handle delete_transcript
    • make sure that handle isoform is also working
  • confirm that undo is working properly
  • create a "delete" page that allows an undo
@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2016

Expand feature_event / changes page so that each entry can be expanded for the full history and also include the operation type. I would advocate throwing angularjs on the front end.

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Nov 19, 2016

@monicacecilia typing: this does not have high priority at the moment because it would require a pretty substantial refactor to prevent it from interfering with current 'History' settings. We will work first on enabling the ability to block permissions to delete.

@monicacecilia monicacecilia modified the milestones: 2.0.6, 2.0.7 Jan 11, 2017

@nathandunn nathandunn changed the title document when a model is deleted document when a model is deleted and make it able to revert Jan 20, 2017

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Jan 20, 2017

Just some internal notes from email:

The other possibility is that we have a “deleted annotations” table that replicates feature (or just a flag in feature).

Again, I think it would be MOST helpful to do a quick sketch / description of the UI (you want a separate page, etc.) you want and then we can derive the data-model and functionality from that.

If we don’t delete history when we delete a feature, that might be one way. We could just show a page for “deleted” features with the ability to undo (admin only?!).

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Jan 20, 2017

Also good to point out that we are not tracking metadata in the same way. Issue is here #541.

@nathandunn nathandunn removed this from the 2.0.7 milestone Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.