Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow the model creator to delete a model (or an admin) #1260

Closed
mpoelchau opened this issue Sep 15, 2016 · 9 comments

Comments

Projects
None yet
4 participants
@mpoelchau
Copy link

commented Sep 15, 2016

Related to #1257: We've occasionally had problems where one curator has deleted a model that another curator has created, without informing them about it. If the original curator wants to retrieve the deleted model, we have to restore it from backups. A curator suggested to us to only allow the model creator to delete a model (or an admin). This seems like a reasonable precaution to me, although it might not be desirable for all the use cases Apollo has to cover. Would it be possible to make this an option that could be configured by the global admin? Has anyone else encountered similar problems?

@nathandunn nathandunn added this to the 2.0.5 milestone Sep 15, 2016

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2016

I was thinking of making this a global admin option.

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Nov 19, 2016

@monicacecilia typing here: we have not come across this case with other groups, because of that I have not prioritized this very highly thus far. This example makes us see the value in enabling this as an admin option... but still to be done in next milestone. Thanks for the report! We'll get to this asap after the upcoming release.

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Jan 20, 2017

From @ loraine-gueguen in #1447 (comment)

This is a need from one of my users: she would like that the annotators could not edit the annotations created by someone else, to prevent conflict.

Another way to handle this, in my opinion, would be to inform the owner (by email or notification inside Apollo) when one of his annotation is modified. This way, it would leave the full collaborative perspective (any annotator can edit any annotation). Moreover, we can imagine that any annotator would have the opportunity to subscribe to the annotations he is interested in to receive notifications when these annotations are modified.

I like the idea of subscription to edits. This could either be internal notification, a report of "my annotations that have been updated by others", or an email (if configured).

@suryasaha

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

Hi @nathandunn,

An email notification of any edits is nice but there should also be an option to prevent this, if desired. This is an important issue for us as we recently had a case where somebody modified a gene model created by another user and used it as a part of a publication without communicating with us. The price of openness :-)

Thanks!

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2017

@suryasaha Yes, we are definitely looking into this. Preventing deletes from a non-owner would be pretty easy to do (yes @mpoelchau let me know if you want a quick hack for this), however preventing a modification to an isoform would be more difficult.

@suryasaha

This comment has been minimized.

Copy link
Member

commented Feb 22, 2017

Thank you for the quick response!

An email notification in case of updates will work out fine as it may be needed in cases where an expert user fixes preliminary gene models created by somebody else (with their knowledge). If the edit is undesirable, will it be possible for an Admin to recover the previous version from the DB and restore it?

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Feb 22, 2017

@suryasaha If the edit is undesirable, you can always revert back via "show history" or undo / redo when you right-click on a feature:

changeannotationhistory2

The exception to this if you delete a feature. There is a feature request #1257 to fix this, but it will be a while until we get this.

I think its good practice to make backups of your production database, daily if possible. Hopefully the history option will serve most of your needs, though.

@suryasaha

This comment has been minimized.

Copy link
Member

commented Feb 23, 2017

@nathandunn Thats good to know. An edit notification will alert us to these changes which can then be addressed. In our case, the annotator had curated 50+ models over 1.5 years and did not realize some models had been modified until we went back to it before final publication.

@nathandunn

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2017

You can also look at the report changes page, which might be helpful as well (prior to publishing):

screen shot 2017-02-23 at 9 26 22 am

screen shot 2017-02-23 at 9 26 13 am

@nathandunn nathandunn added ready and removed discussion labels Jul 7, 2017

@nathandunn nathandunn self-assigned this Jul 10, 2017

@nathandunn nathandunn added ready and removed ready labels Jul 10, 2017

nathandunn added a commit to nathandunn/Apollo that referenced this issue Jul 16, 2017

@nathandunn nathandunn added in progress and removed ready labels Jul 16, 2017

@nathandunn nathandunn referenced this issue Jul 16, 2017

Merged

fixes #1260 #1700

@ghost ghost removed the in progress label Jul 19, 2017

nathandunn added a commit that referenced this issue Jul 19, 2017

fixes #1260 (#1700)
* fixes #1260

* added instructions

* override default colorCdsByFrame to ture

* Update Configure.md

* needed to find the owners in order to compare properly

* made changes per review

* add hooks for preventing deletion when changing types and changed text to reflect

@nathandunn nathandunn referenced this issue Aug 22, 2018

Closed

Permissions #1931

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.