Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo should recognize jbrowse dot notation #1839

Closed
nathandunn opened this issue Jan 10, 2018 · 3 comments

Comments

@nathandunn
Copy link
Contributor

commented Jan 10, 2018

FYI @childers Let me know if this is correct.

@childers

This comment has been minimized.

Copy link
Collaborator

commented Jan 11, 2018

@nathandunn Do you have some examples or a description of what the JBrowse dot notation looks like? I'm reading about dot notation in general, but have never used that term before.

In general, the parameters getting processed during login, authenticated (and possibly logout) events are not being handled correctly in the URL param format.

The closed issue #1840 has some additional information and server log entries if that helps. Otherwise, just let me know what information you need and I'll pull it together.

@nathandunn

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2018

@childers This is the library I am using. https://github.com/rhalff/dot-object

Keep in mind there are some simplifications as well.

Also, I was wrong earlier about the addStores. It documented it correctly, but I'm not sure why I made the implementation addStore. I've fixed it on the JBrowse end. There are a couple of things we need to fix on the Apollo end on #1842 that @deepakunni3 is looking into.

@nathandunn

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2018

Closed by #1842

@nathandunn nathandunn closed this Jan 12, 2018
@ghost ghost removed the in progress label Jan 12, 2018
@nathandunn nathandunn modified the milestones: 2.0.9, 2.1.0 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.